Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy upgrade including Bootstrap v5 #2490

Merged
merged 10 commits into from Mar 13, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 13, 2023

⚠️ NOTE: website contributors should run the following commands after this PR gets merged:

$ nvm use
$ npm install

@svrnm @cartermp - I've walked through most of the site and addressed all problems or created a corresponding issue. PTAL. Note that slight layout changes are to be expected, a result of Bootstrap style tweaks.

Preview: https://deploy-preview-2490--opentelemetry.netlify.app/

@chalin chalin added dependencies Pull requests that update a dependency file docsy design/style Front-end site design / styling labels Mar 13, 2023
@chalin chalin requested a review from a team as a code owner March 13, 2023 00:21
@chalin chalin mentioned this pull request Mar 13, 2023
7 tasks
@svrnm
Copy link
Member

svrnm commented Mar 13, 2023

clicked through a few pages, all looks good, @chalin please merge if you think you're ready

@chalin chalin force-pushed the chalin-im-docsy-2023-03-04 branch from cf99ac0 to 8116937 Compare March 13, 2023 15:49
@chalin
Copy link
Contributor Author

chalin commented Mar 13, 2023

I've added a note to the opening comment to remind contributors to run at least npm install after this PR lands. If they don't they'll get an error message.

@chalin chalin merged commit 6a4b374 into open-telemetry:main Mar 13, 2023
5 checks passed
@chalin chalin deleted the chalin-im-docsy-2023-03-04 branch March 13, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file design/style Front-end site design / styling docsy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants