Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix(eslint-plugin-lit-a11y): fix required aria-controls #1944

Closed
wants to merge 1 commit into from

Conversation

thepassle
Copy link
Member

No description provided.

{ code: 'html`<input type="checkbox" role="switch" aria-checked="true" />`' },
{ code: 'html`<div role="combobox" aria-controls="foo" aria-expanded="foo"></div>`' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove what looks like a valid combo box usage? Seems like we’d want to test this...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this as <div role="combobox" aria-expanded="foo"></div> instead of removing?

@thepassle thepassle changed the title fix(eslint-plugin-lit-a11y): fix required aria-controls WIP: fix(eslint-plugin-lit-a11y): fix required aria-controls Oct 24, 2020
@stale
Copy link

stale bot commented Nov 16, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Nov 16, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Open Web Components!

@stale stale bot closed this Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants