This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Implement perfect negotiation. #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taste1981
reviewed
Apr 8, 2021
taste1981
reviewed
Apr 8, 2021
docs/design/perfect_negotiation.md
Outdated
|
|
||
| ## Connections | ||
|
|
||
| We expect only one `PeerConnection` between two endpoints. A random ID is generated when creating a new `PeerConnection`. All messages (offers, answers, ICE candidates) for this `PeerConnection` have a `connectionId` property with the connection ID as its value. |
Collaborator
There was a problem hiding this comment.
Please clarify if Client A and Client B sets up the peer connection, will connectionId value to be the same for both?
Collaborator
Author
There was a problem hiding this comment.
Fixed. Connection ID is shared by both clients.
taste1981
reviewed
Apr 8, 2021
docs/design/perfect_negotiation.md
Outdated
|
|
||
| ## Behaviors | ||
|
|
||
| When WebRTC collision occurred, it basically follows the perfect negotiation example in WebRTC 1.0. This section only describes the implementation for signaling collision. |
taste1981
reviewed
Apr 8, 2021
taste1981
reviewed
Apr 8, 2021
Negotiation needed works good now, the SDK doesn't need to handle negotiation needed flag manually.
taste1981
approved these changes
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement perfect negotiation to avoid collision.