Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and pack issue. #103

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
3 participants
@Piasy
Copy link
Contributor

Piasy commented Apr 12, 2019

  1. In Ubuntu server with less than 8 cores, -j 8 would hang the build process, using the number of cores could fix it;
  2. Update scripts according to the new owt-client-javascript structure;

@Piasy Piasy changed the base branch from master to 4.2.x Apr 12, 2019

@Piasy Piasy changed the base branch from 4.2.x to master Apr 12, 2019

@xiandeatintel xiandeatintel requested a review from starwarfan Apr 16, 2019

@starwarfan

This comment has been minimized.

Copy link
Collaborator

starwarfan commented Apr 16, 2019

Hi, Piasy
When you use the "--sample-path" option, you need use "${javascript-repo-root}/dist/samples/conference".
Like '--sample-path ~/owt-js-sdk/dist/sample/conference', this should work.
Our CI test uses this sample-path, so you PR cannot pass.
According to your problem, the description in README.md should be refined later.

@starwarfan
Copy link
Collaborator

starwarfan left a comment

the cpu part is OK, but the 'sample-path' issue is better to fixed in README

@Piasy

This comment has been minimized.

Copy link
Contributor Author

Piasy commented Apr 16, 2019

Okey, I'll update this PR :)

Fix build issue, and update README about pack parameter.
In Ubuntu server with less than 8 cores, `-j 8` would hang the build process, using the number of cores could fix it;

@Piasy Piasy force-pushed the Piasy:fix_build_pack branch from b2d7e7d to e5c0650 Apr 16, 2019

@xiandeatintel xiandeatintel merged commit c04431a into open-webrtc-toolkit:master Apr 18, 2019

2 checks passed

ci/jenkins/server Build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@xiandeatintel

This comment has been minimized.

Copy link
Collaborator

xiandeatintel commented Apr 18, 2019

Thanks @Piasy for contribution. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.