Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard handling does not work on Mac #5

Closed
dtinth opened this issue Jun 9, 2011 · 8 comments
Closed

Keyboard handling does not work on Mac #5

dtinth opened this issue Jun 9, 2011 · 8 comments
Labels

Comments

@dtinth
Copy link
Member

dtinth commented Jun 9, 2011

On Mac OS X, open2jam seems to not be able to handle any key presses, instead, the program freezes.

It does not crash, it just doesn't respond to user events anymore.

For example, when playing a song, the notes will drop just fine, but you can't press any keys. You can't close the window either. The same also happens on keyboard configuration screen, after you click on a row and a dialog box pops up, the app freezes too.

@mrcdk
Copy link
Member

mrcdk commented Jun 9, 2011

Well, that will be pretty hard to fix because I think none of us have a mac xD Last time open2jam was tested on one the only problem was that it wasn't handling the esc key but other things were ok :/ And as far as i know the keyboard handling hasn't being touched after that.

@chaosfox
Copy link
Member

chaosfox commented Jun 9, 2011

@dtinth Is this a regression ? I mean, this is the first time you are testing or did it worked in previous versions ?

Edit: this is probably the problem http://lwjgl.org/forum/index.php/topic,3660.0.html

@dtinth
Copy link
Member Author

dtinth commented Jun 9, 2011

It didn't work since the first time I tried it on Mac OS X, and that was since alpha 5.

And yes the third post in that link does make sense.

@chaosfox
Copy link
Member

chaosfox commented Jun 9, 2011

I made the render execute on a separate thread on branch keyboard_mac, now we need to test it somehow, if I make you a build can you test it ?

@dtinth
Copy link
Member Author

dtinth commented Jun 9, 2011

Yes. That would be very convenient for me.

I'm actually trying to download NetBeans here, but that's gonna take some time, so a build would be cool :D.

@chaosfox
Copy link
Member

chaosfox commented Jun 9, 2011

here: https://github.com/downloads/chaosfox/open2jam/open2jam_keyboardmac.zip
thats only the jar actually, just replace with the other one, the rest doesn't change.

@dtinth
Copy link
Member Author

dtinth commented Jun 9, 2011

Yes, it works. Awesome!

Thanks. :)

@chaosfox
Copy link
Member

chaosfox commented Jun 9, 2011

Solved then ! thank you for reporting the bug.

dtinth added a commit that referenced this issue Oct 1, 2012
Refactor the judgment system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants