fix: DRB lost issue when additional TFTs needs to be added to existing bearer with TFTs #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g bearer with TFTs This commit address the issue where a bearer with particular PCC rule name exists with TFTs and addtional TFTs needs to be added to same bearer and DRB lost is reported by UE. This is achieved by creating EPS Bearer Level Traffic Flow Template with TFT operation code as 'OGS_GTP_TFT_CODE_ADD_PACKET_FILTERS_TO_EXISTING_TFT' in above scenario rather than use 'OGS_GTP_TFT_CODE_CREATE_NEW_TFT' at all times. And, not remove existing packet filters for the bearer.
acetcom
added a commit
that referenced
this pull request
May 28, 2021
commit 183d8b8344122f25f77be79b1b698c71f48c1656
Author: Sukchan Lee <acetcom@gmail.com>
Date: Fri May 28 23:44:26 2021 +0900
[SMF] introduce new list API [#1019]
Sometimes we may need two lists for same node.
To do this, I created a new list API, and applied it this pull request.
|
You have constructed two lists(bearer->pf_list and pf_to_add_list) for one node(smf_pf_t). I've analyzed your code and I don't think there are any bugs. However, I think this approach can be misleading and confusing when others read this code. So, I created a new list API and modified it like that. And also, I changed the smf_pf_find_by_flow() location. Let me know if you have any different idea. Thank you for your great work! |
|
Nice solution. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit address the issue where a bearer with particular
PCC rule name exists with TFTs and addtional TFTs needs to be added
to same bearer and DRB lost is reported by UE.
This is achieved by creating EPS Bearer Level Traffic Flow Template
with TFT operation code as 'OGS_GTP_TFT_CODE_ADD_PACKET_FILTERS_TO_EXISTING_TFT' in
above scenario rather than use 'OGS_GTP_TFT_CODE_CREATE_NEW_TFT' at all times.
And, not remove existing packet filters for the bearer.
Attaching the pcap containing the issue, observe that after packet 1883, the RTP packets are flowing over default bearer for IMS signalling
drb_lost_before_fix.zip