fix(server): Return error code if node adding fails

open62541 · Aug 17, 2020 · 3120c35 · 3120c35
1 parent 415f55c
commit 3120c35
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/server/ua_services_nodemanagement.c b/src/server/ua_services_nodemanagement.c
@@ -1096,7 +1096,7 @@ recursiveTypeCheckAddChildren(UA_Server *server, UA_Session *session,
     }
 
     /* Add (mandatory) child nodes from the direct HasInterface reference */
-    if(node->head.nodeClass == UA_NODECLASS_OBJECT) {
+    if(retval == UA_STATUSCODE_GOOD && node->head.nodeClass == UA_NODECLASS_OBJECT) {
         retval = addInterfaceChildren(server, session, &node->head);
         if(retval != UA_STATUSCODE_GOOD) {
             UA_LOG_NODEID_WRAP(&node->head.nodeId, UA_LOG_INFO_SESSION(&server->config.logger, session,
@@ -1106,7 +1106,7 @@ recursiveTypeCheckAddChildren(UA_Server *server, UA_Session *session,
         }
     }
 
-    return UA_STATUSCODE_GOOD;
+    return retval;
 }
 
 /* Construct children first */