Skip to content

Conversation

@Priyanka488
Copy link
Contributor

@Priyanka488 Priyanka488 commented Mar 5, 2019

Fixes #1073

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

implementation fileTree(dir: 'src/main/libs', include: ['*.jar'])

//DBFlow dependencies
annotationProcessor "com.github.Raizlabs.DBFlow.dbflow:dbflow-processor:3.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droidchef Yes, because initially while building the project , we all were getting the annotation processor error , though the annotation settings were set to be true.

Copy link
Member

@droidchef droidchef Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


       annotationProcessor "com.github.Raizlabs.DBFlow:dbflow-processor:$rootProject.raizLabsDBFlow"
       annotationProcessor "com.github.Raizlabs.DBFlow.dbflow:dbflow-processor:3.1.1"


You see, we have two annotationProcessor lines trying to fetch the same thing. I can imagine one of them is not working and that's why, I am asking do we need both, if not, can you remove the wrong/redundant one, please :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droidchef I have removed the redundant one , kindly review . : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droidchef Please have a look.

and direct binary dependencies.
"Annotation processors must be explicitly declared now".
"Program type already present for com.github.Raizlabs.DBFlow:dbflow"

Resolved by removing the binary dependency from the gradle file and by
explicitly declaring the required annotation processors.
@droidchef droidchef merged commit d9af6b5 into openMF:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants