Skip to content

Conversation

@laxyapahuja
Copy link
Contributor

@laxyapahuja laxyapahuja commented Dec 4, 2019

Fixes #1182

Task Link

ezgif-4-25bd4b5d4d62

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@laxyapahuja
Copy link
Contributor Author

Will fix style violations tomorrow.

@moksh-mahajan
Copy link
Collaborator

Hi @laxyapahuja, did you claim the task on the GCI portal before sending the PR?

@laxyapahuja
Copy link
Contributor Author

Hi @laxyapahuja, did you claim the task on the GCI portal before sending the PR?

Hey @moksh-mahajan , I didn't know earlier that you weren't allowed to make a PR without claiming a task. Will claim this task right after my current one gets approved.

@moksh-mahajan
Copy link
Collaborator

moksh-mahajan commented Dec 7, 2019

@laxyapahuja Another student has already claimed the task. So, you can claim it if he/she abandons the task or in case fails to do it in the given time period.

@laxyapahuja
Copy link
Contributor Author

@moksh-mahajan i've claimed this task on the dashboard now. can you please review it? :D

Copy link
Collaborator

@luckyman20 luckyman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit title too.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the mentioned

@ghost
Copy link

ghost commented Dec 13, 2019

@luckyman20 I think it probably has issues when uploaded image sizes are very high, like 3-4 MB, could you take a look into this?

@laxyapahuja
Copy link
Contributor Author

@luckyman20 I think it probably has issues when uploaded image sizes are very high, like 3-4 MB, could you take a look into this?

It's most probably a server side problem as it showed me the error as 403 HTTP FORBIDDEN.

Copy link
Collaborator

@luckyman20 luckyman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Laxya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No options to upload existing photo in Edit client page.

3 participants