-
Notifications
You must be signed in to change notification settings - Fork 654
Add an option to upload existing image in Client Profile #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Will fix style violations tomorrow. |
|
Hi @laxyapahuja, did you claim the task on the GCI portal before sending the PR? |
Hey @moksh-mahajan , I didn't know earlier that you weren't allowed to make a PR without claiming a task. Will claim this task right after my current one gets approved. |
|
@laxyapahuja Another student has already claimed the task. So, you can claim it if he/she abandons the task or in case fails to do it in the given time period. |
|
@moksh-mahajan i've claimed this task on the dashboard now. can you please review it? :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commit title too.
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do the mentioned
|
@luckyman20 I think it probably has issues when uploaded image sizes are very high, like 3-4 MB, could you take a look into this? |
It's most probably a server side problem as it showed me the error as 403 HTTP FORBIDDEN. |
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, Laxya!
Fixes #1182
Task Link
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.