From ccd6e3e2d7ed967579d4ff028abc6a953fff4afa Mon Sep 17 00:00:00 2001 From: robustTechie Date: Sat, 20 Feb 2021 13:31:06 +0530 Subject: [PATCH] Lint bug fixed --- mifosng-android/build.gradle | 7 +-- .../pathtracking/PathTrackingService.java | 45 +++++++++++++++++++ .../CollectionSheetDialogFragment.java | 1 - .../res/layout/activity_pinpoint_location.xml | 3 +- .../main/res/layout/fragment_centers_list.xml | 3 +- .../main/res/layout/fragment_charge_list.xml | 3 +- .../src/main/res/layout/fragment_client.xml | 3 +- .../layout/fragment_client_identifiers.xml | 3 +- .../main/res/layout/fragment_datatable.xml | 3 +- .../main/res/layout/fragment_datatables.xml | 3 +- .../res/layout/fragment_document_list.xml | 3 +- .../main/res/layout/fragment_group_list.xml | 3 +- .../src/main/res/layout/fragment_groups.xml | 3 +- .../src/main/res/layout/fragment_notes.xml | 3 +- .../res/layout/fragment_offline_dashboard.xml | 3 +- .../fragment_savings_account_transaction.xml | 6 ++- .../main/res/layout/fragment_survey_last.xml | 1 - .../main/res/layout/fragment_syncpayload.xml | 3 +- .../main/res/layout/item_client_runreport.xml | 3 +- .../main/res/layout/row_center_list_item.xml | 2 +- .../src/main/res/layout/row_client_name.xml | 2 +- .../src/main/res/layout/row_group_name.xml | 2 +- .../main/res/layout/row_identifier_list.xml | 2 +- .../main/res/layout/row_surveys_list_item.xml | 3 +- .../res/layout/view_nav_drawer_header.xml | 2 +- .../main/res/menu/menu_client_save_pin.xml | 3 +- 26 files changed, 90 insertions(+), 28 deletions(-) diff --git a/mifosng-android/build.gradle b/mifosng-android/build.gradle index 5ec80122528..36d0a96ce3d 100755 --- a/mifosng-android/build.gradle +++ b/mifosng-android/build.gradle @@ -110,6 +110,7 @@ android { lintOptions { abortOnError false disable 'InvalidPackage' + disable 'MissingTranslation' } @@ -196,7 +197,7 @@ dependencies { kapt 'androidx.lifecycle:lifecycle-compiler:2.0.0' //Square dependencies - implementation('com.squareup.retrofit2:retrofit:$rootProject.retrofitVersionLatest') { + implementation("com.squareup.retrofit2:retrofit:$rootProject.retrofitVersionLatest") { // exclude Retrofit’s OkHttp peer-dependency module and define your own module import exclude module: 'okhttp' } @@ -216,8 +217,8 @@ dependencies { implementation 'com.facebook.stetho:stetho-okhttp3:1.3.1' - implementation 'com.joanzapata.iconify:android-iconify-material:2.1.1' // (v2.0.0) - implementation('com.crashlytics.sdk.android:crashlytics:2.6.6@aar') { + implementation "com.joanzapata.iconify:android-iconify-material:2.1.1" // (v2.0.0) + implementation('com.crashlytics.sdk.android:crashlytics:17.2.2@aar') { transitive = true } implementation 'com.amulyakhare:com.amulyakhare.textdrawable:1.0.1' diff --git a/mifosng-android/src/main/java/com/mifos/mifosxdroid/activity/pathtracking/PathTrackingService.java b/mifosng-android/src/main/java/com/mifos/mifosxdroid/activity/pathtracking/PathTrackingService.java index d52fca3823d..34d2d713dbb 100644 --- a/mifosng-android/src/main/java/com/mifos/mifosxdroid/activity/pathtracking/PathTrackingService.java +++ b/mifosng-android/src/main/java/com/mifos/mifosxdroid/activity/pathtracking/PathTrackingService.java @@ -5,6 +5,7 @@ package com.mifos.mifosxdroid.activity.pathtracking; +import android.Manifest; import android.app.NotificationManager; import android.app.PendingIntent; import android.app.Service; @@ -12,10 +13,14 @@ import android.content.Context; import android.content.Intent; import android.content.IntentFilter; +import android.content.pm.PackageManager; import android.location.Location; import android.os.Bundle; import android.os.IBinder; + +import androidx.core.app.ActivityCompat; import androidx.core.app.NotificationCompat; + import android.util.Log; import android.widget.Toast; @@ -102,6 +107,26 @@ protected void createLocationRequest() { } protected void startLocationUpdates() { + if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) { + // TODO: Consider calling + // ActivityCompat#requestPermissions + // here to request the missing permissions, and then overriding + // public void onRequestPermissionsResult(int requestCode, String[] permissions, + // int[] grantResults) + // to handle the case where the user grants the permission. See the documentation + // for ActivityCompat#requestPermissions for more details. + return; + } + if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) { + // TODO: Consider calling + // ActivityCompat#requestPermissions + // here to request the missing permissions, and then overriding + // public void onRequestPermissionsResult(int requestCode, String[] permissions, + // int[] grantResults) + // to handle the case where the user grants the permission. See the documentation + // for ActivityCompat#requestPermissions for more details. + return; + } LocationServices.FusedLocationApi.requestLocationUpdates( googleApiClient, locationRequest, this); } @@ -124,6 +149,26 @@ public int onStartCommand(Intent intent, int flags, int startId) { @Override public void onConnected(Bundle bundle) { if (currentLocation == null) { + if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) { + // TODO: Consider calling + // ActivityCompat#requestPermissions + // here to request the missing permissions, and then overriding + // public void onRequestPermissionsResult(int requestCode, String[] permissions, + // int[] grantResults) + // to handle the case where the user grants the permission. See the documentation + // for ActivityCompat#requestPermissions for more details. + return; + } + if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) { + // TODO: Consider calling + // ActivityCompat#requestPermissions + // here to request the missing permissions, and then overriding + // public void onRequestPermissionsResult(int requestCode, String[] permissions, + // int[] grantResults) + // to handle the case where the user grants the permission. See the documentation + // for ActivityCompat#requestPermissions for more details. + return; + } currentLocation = LocationServices.FusedLocationApi.getLastLocation(googleApiClient); latLngs.add(new UserLatLng(currentLocation.getLatitude(), currentLocation.getLongitude())); diff --git a/mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/collectionsheetdialog/CollectionSheetDialogFragment.java b/mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/collectionsheetdialog/CollectionSheetDialogFragment.java index 5212be38ba0..83653165040 100644 --- a/mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/collectionsheetdialog/CollectionSheetDialogFragment.java +++ b/mifosng-android/src/main/java/com/mifos/mifosxdroid/dialogfragments/collectionsheetdialog/CollectionSheetDialogFragment.java @@ -56,7 +56,6 @@ public static CollectionSheetDialogFragment newInstance(String date, int members @Override public void onCreate(Bundle savedInstanceState) { - super.onCreate(savedInstanceState); ((MifosBaseActivity) getActivity()).getActivityComponent().inject(this); date = getArguments().getString(Constants.REPAYMENT_DATE); members = getArguments().getInt(Constants.MEMBERS); diff --git a/mifosng-android/src/main/res/layout/activity_pinpoint_location.xml b/mifosng-android/src/main/res/layout/activity_pinpoint_location.xml index b1f5383b3d0..1cf764556b4 100644 --- a/mifosng-android/src/main/res/layout/activity_pinpoint_location.xml +++ b/mifosng-android/src/main/res/layout/activity_pinpoint_location.xml @@ -7,6 +7,7 @@ @@ -43,7 +44,7 @@ android:layout_width="48dp" android:layout_height="48dp" android:layout_gravity="center" - android:src="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp"/> @@ -43,7 +44,7 @@ android:layout_height="wrap_content" android:layout_gravity="bottom|end" android:layout_margin="16dp" - android:src="@drawable/ic_add_white_24dp"/> + app:srcCompat="@drawable/ic_add_white_24dp"/> @@ -37,7 +38,7 @@ android:layout_width="48dp" android:layout_height="48dp" android:layout_gravity="center" - android:src="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp"/> @@ -40,7 +41,7 @@ android:layout_height="wrap_content" android:layout_gravity="bottom|end" android:layout_margin="16dp" - android:src="@drawable/ic_add_white_24dp"/> + app:srcCompat="@drawable/ic_add_white_24dp"/> @@ -38,7 +39,7 @@ android:layout_width="48dp" android:layout_height="48dp" android:layout_gravity="center" - android:src="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp"/> @@ -50,7 +51,7 @@ android:layout_width="48dp" android:layout_height="48dp" android:layout_gravity="center" - android:src="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp"/> @@ -46,7 +47,7 @@ android:layout_width="48dp" android:layout_height="48dp" android:layout_gravity="center" - android:src="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp" /> @@ -44,7 +45,7 @@ android:layout_height="wrap_content" android:layout_gravity="bottom|end" android:layout_margin="16dp" - android:src="@drawable/ic_add_white_24dp"/> + app:srcCompat="@drawable/ic_add_white_24dp"/> @@ -37,7 +38,7 @@ android:layout_width="48dp" android:layout_height="48dp" android:layout_gravity="center" - android:src="@drawable/ic_error_black_24dp" /> + app:srcCompat="@drawable/ic_error_black_24dp" /> @@ -38,7 +39,7 @@ android:layout_width="48dp" android:layout_height="48dp" android:layout_gravity="center" - android:src="@drawable/ic_error_black_24dp"/> + app:srcCompat="@drawable/ic_error_black_24dp"/> + android:text="@string/cancel" + android:layout_alignParentLeft="true" />