Fix: failed to fetch loan template #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therajanmaurya @droidchef Please review it. |
droidchef
requested changes
Aug 15, 2017
| this.interestRateFrequencyType = in.readParcelable(InterestRateFrequencyType.class | ||
| .getClassLoader()); | ||
| this.annualInterestRate = (Integer) in.readValue(Integer.class.getClassLoader()); | ||
| this.annualInterestRate = (Double) in.readValue(Integer.class.getClassLoader()); |
There was a problem hiding this comment.
Integer.class.getClassLoader and casting it to Double, Why ?
|
@droidchef Sorry, my bad. I have corrected that. You can merge it now. :) |
|
@therajanmaurya Please review it. |
|
@droidchef @therajanmaurya Please review. :) |
|
demo.mifos works fine but the issue continues when u change demo.mifos to your own server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #747
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.