Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes issue #3001. datepicker disables dates before 1st Jan #3008
For the datatable date input field, min value was set to minDate. Issue was it was taking some default min value which was 1st of Jan of the current year so when the min value was explicitly set, it allows earlier dates.
Related issues and discussion
Screenshots, if any
Please make sure these boxes are checked before submitting your pull request - thanks!
Thanks for your suggestion. Have you tested and confirmed that the similar issue exists with DateTime field? If so, suggest that we track DateTime as a separate issue.
Rationale: Good software development practice is to create separate tickets for separate issues:
Another guide says be specific:
As an Open Source project, I think if there is no technical issues with PR and it fixes the issue, it should be accepted. Even if contributors had the bandwidth to add multiple fixes into single tickets, it is better to track issues separately.
@terencemo thanks for sharing guidelines. Yes, the date time issue is easily identifiable and should have been covered in the issue.
@ShruthiRajaram currently I don't have bandwidth to test the DateTime field and I think it should be a separate issue. There are organisations using Mifos X which have DataTables with only date fields. This will solve the issue they are facing. I haven't received a clear answer whether you have tested and can confirm the issue occurs for DateTime fields. If you have, suggest you to raise a separate issue. Also, you say
Can you explain the basis of this assessment?
@edcable, @mgeiss, @nazeer1100126 if your team has consensus that you don't want to create separate tickets to track different issues and wan't to combine related tickets, would you suggest we close this PR? Also it will be helpful for contributors to update https://github.com/openMF/community-app/blob/develop/Contributing.md regarding combining issues in a PR. If we are deviating from mainstream Open Source practices, I think we should document the same properly.