Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1153: Fixed the aligment of account number #1168

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@jatinkumarg
Copy link

commented Apr 15, 2019

Fixes #1153

New changes
apply_for_loan

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@shiv07tiwari

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@jatinkumarg You should first ask the person who has opened the issue, and if he is not working on it, then only should send a PR.

@jatinkumarg

This comment has been minimized.

Copy link
Author

commented Apr 15, 2019

@shiv07tiwari Apologies, since there was no one assigned to the #1153 and the issue has been open for 12 days, I thought anyone can fix this issue.

So I submitted this PR 14 hours ago and then I saw you submitted another PR with the same fix just three hours ago.

Look I was just trying to help. But now I am kind of disappointed with the professionalism in this Open Source community. I hope you understand my point of view.

@RajaVamsi11

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@jatinkumarg It okay but try not to make this mistake again.

@shiv07tiwari

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@jatinkumarg Its not about the professionalism, but is about following the basic rules of open source contributions. We all are here to help and solve the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.