Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Fix GitHub Actions macOS workflow for pull requests. #1621

Merged
merged 1 commit into from
May 13, 2024

Conversation

grauw
Copy link
Contributor

@grauw grauw commented May 13, 2024

Pull requests don’t have access to the secrets, for good reason, however this causes the macOS builds to fail in the signing preparation step. This change adds a check on whether the secret is available, and if not, skips the step.

This pull request should tell us whether this actually works.

@grauw grauw changed the title Workflow: Fix GitHub Actions workflow for pull requests. Workflow: Fix GitHub Actions macOS workflow for pull requests. May 13, 2024
Pull requests don’t have access to the secrets, for good reason, however this
causes the macOS builds to fail in the signing preparation step. This change
adds a check on whether the secret is available, and if not, skips the step.
@grauw grauw merged commit 244eabd into openMSX:master May 13, 2024
5 checks passed
@grauw grauw deleted the fix-macos-pull-workflow branch May 13, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant