New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(UI) bugs due to frontend overhaul #375

Closed
gedankenstuecke opened this Issue Jun 2, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@gedankenstuecke
Copy link
Member

gedankenstuecke commented Jun 2, 2017

With merging #365 we got some (mainly UI) bugs that we need to tend to:

  • Glyphicons in production are broken.
  • Avatar for @gedankenstuecke doesn't load on About Us
  • Modals for entering new phenotypes are white text on white background
  • Numbered Pagination came back, see #329 for fix
  • "Latest Data"-tab loads forever, ineffective database queries?
  • Pie charts for allele/genotype frequencies don't have legend.
  • Fitbit graphs are also strange.
  • Remove #{@user.name} SNPs on _user_not_user.html.erb
  • Remove index-column on index.html.erb for users & genotypes
  • Phenotype entry autocompletion is somewhat broken (on modal an phenotype page directly)

Add your own things below 😂

@gedankenstuecke

This comment has been minimized.

Copy link
Member

gedankenstuecke commented Jun 2, 2017

Replacing my avatar with a PNG instead of JPEG worked. No clue why, should investigate this.

@gedankenstuecke

This comment has been minimized.

Copy link
Member

gedankenstuecke commented Jun 2, 2017

#379 also closes the broken modals. My bad for not switching branches in time.

@gedankenstuecke

This comment has been minimized.

Copy link
Member

gedankenstuecke commented Jun 2, 2017

With the UI update #223 seems to be at least a bit better now. The Autocomplete on the modal phenotype entry works if you cycle through it with your arrow keys, but it doesn't show the actual selection in a sensible way so far. Might be some CSS/JS updates that killed it.

@philippbayer

This comment has been minimized.

Copy link
Member

philippbayer commented Jun 3, 2017

Glyphicons have been fixed, see #383

@gedankenstuecke

This comment has been minimized.

Copy link
Member

gedankenstuecke commented Jun 3, 2017

Yay, thanks! 🙏

gedankenstuecke added a commit that referenced this issue Jun 3, 2017

philippbayer added a commit that referenced this issue Jun 3, 2017

@gvd

This comment has been minimized.

Copy link

gvd commented Jun 19, 2017

Regarding the phenotype autocomplete. I see the following code:

$(function () {
        $("#phenotype_characteristic").autocomplete({
            source: ["Retrognathia (Marfan Syndrome)", "....."]
        });

Which is missing some brackets. It should be:

$(function () {
        $("#phenotype_characteristic").autocomplete({
            source: ["Retrognathia (Marfan Syndrome)", "....."] 
        }); 
}); // <----------------

gvd added a commit to gvd/snpr that referenced this issue Jun 19, 2017

Fix phenotype entry autocomplete for openSNP#375
It was missing a few brackets

gedankenstuecke added a commit that referenced this issue Jun 19, 2017

Fix phenotype entry autocomplete for #375 (#410)
It was missing a few brackets
@gedankenstuecke

This comment has been minimized.

Copy link
Member

gedankenstuecke commented Jun 19, 2017

#411 closes the last one of the bugs reported here so far. 🎉

philippbayer added a commit that referenced this issue Jun 20, 2017

Merge pull request #411 from openSNP/phenotype_view
fixed modal autocomplete! closes #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment