From 98e1770eef9196745e7da52a8f1c0c4eb4537e9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20D=C3=ADaz=20Gonz=C3=A1lez?= Date: Tue, 9 May 2023 23:12:23 +0100 Subject: [PATCH 1/2] [web] Increase the z-index of the sidebar To avoid other elements overlapping it. A very high value was chosen because PatternFly uses values from 100 to 600 at the time of writing. See [1] Another option could be to use the PatternFly highest value, but for now it does not seem necessary to couple the Sidebar z-index to a PatternFly variable. [1] https://github.com/patternfly/patternfly/blob/7ddc2de5cfb96f204e62730878a9e77bed64b998/src/patternfly/sass-utilities/scss-variables.scss#L154-L160 --- web/src/assets/styles/blocks.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/assets/styles/blocks.scss b/web/src/assets/styles/blocks.scss index baf603ea2d..dcd9e0cf80 100644 --- a/web/src/assets/styles/blocks.scss +++ b/web/src/assets/styles/blocks.scss @@ -82,7 +82,7 @@ section > .content { position: absolute; padding: 0; right: 0; - z-index: 1; + z-index: 1000; inline-size: 70%; box-shadow: -10px 10px 20px 0 var(--color-primary); } From a25ac3ebe4ebb723e613c1a7cec20e45dee711a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20D=C3=ADaz=20Gonz=C3=A1lez?= Date: Tue, 9 May 2023 23:37:57 +0100 Subject: [PATCH 2/2] [web] Add an entry in the changes file --- web/package/cockpit-agama.changes | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/web/package/cockpit-agama.changes b/web/package/cockpit-agama.changes index b99eb23a50..ba168aa8ba 100644 --- a/web/package/cockpit-agama.changes +++ b/web/package/cockpit-agama.changes @@ -1,9 +1,14 @@ +------------------------------------------------------------------- +Tue May 9 22:36:12 UTC 2023 - David Diaz + +- Keep the sidebar on top of other elements when it's open + (gh#openSUSE/agama#569). + ------------------------------------------------------------------- Mon May 8 15:20:14 UTC 2023 - David Diaz - Set sidebar siblings as aria-hiden while it's open (gh#openSUSE/agama#563) - ------------------------------------------------------------------- Fri Apr 28 15:16:04 UTC 2023 - José Iván López González