Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: update systemsmanagement:Agama:Staging in OBS #606

Merged
merged 32 commits into from
Jun 8, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jun 6, 2023

Problem

Solution

Notes

As the GitHub workflow is executed only for the master branch there is no run for the last commits. If you want to see an example run check the actions history where I enabled the run also for the branch for this pull request.

The rake osc:commit by default calls osc:build target as a dependency. But building the Ruby gem package does not provide much value (it basically just unpack the files from *.gem to /usr/lib64/ruby... and compress that to an RPM). It just makes the submission much longer (1min -> 3mins).

Additional Changes

  • Use --local option when building the Ruby gem, it is much faster (1sec vs. 15sec) and the generated file is the same
  • Build the gem version from git tag + offset, do not hardcode it in a file

Tasks

  • Synchronize the agama-cli package
  • Synchronize the cockpit-agama package
  • Synchronize the cockpit-agama-playwright package
  • Synchronize the rubygem-agama package
  • Share some parts of the workflow (GitHub documentation)
  • Add documentation

@coveralls
Copy link

coveralls commented Jun 6, 2023

Pull Request Test Coverage Report for Build 5211544306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.998%

Totals Coverage Status
Change from base Build 5200965155: 76.0%
Covered Lines: 5255
Relevant Lines: 6672

💛 - Coveralls

@lslezak lslezak marked this pull request as ready for review June 8, 2023 14:21
jobs:
update_staging_package:
# do not run in forks
if: github.repository == 'openSUSE/agama'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we here also force only master branch?

Copy link
Contributor

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It looks great and it is well-documented. Great job!

spec.version = File.read("VERSION").chomp
# the version is <version_tag>.devel<number_of_commits_since_the_tag>
# or just <version_tag> if there are no additional commits
spec.version = `git describe --tags`.chomp.sub(/^v/, "").sub(/-([0-9]+)-g\h+\Z/, ".devel\\1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lslezak lslezak merged commit 95e288d into master Jun 8, 2023
@lslezak lslezak deleted the obs_sync branch June 8, 2023 14:39
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants