-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: update systemsmanagement:Agama:Staging in OBS #606
Conversation
Pull Request Test Coverage Report for Build 5211544306
💛 - Coveralls |
This reverts commit 7872d26.
jobs: | ||
update_staging_package: | ||
# do not run in forks | ||
if: github.repository == 'openSUSE/agama' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we here also force only master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! It looks great and it is well-documented. Great job!
spec.version = File.read("VERSION").chomp | ||
# the version is <version_tag>.devel<number_of_commits_since_the_tag> | ||
# or just <version_tag> if there are no additional commits | ||
spec.version = `git describe --tags`.chomp.sub(/^v/, "").sub(/-([0-9]+)-g\h+\Z/, ".devel\\1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Problem
Solution
Notes
As the GitHub workflow is executed only for the master branch there is no run for the last commits. If you want to see an example run check the actions history where I enabled the run also for the branch for this pull request.
The
rake osc:commit
by default callsosc:build
target as a dependency. But building the Ruby gem package does not provide much value (it basically just unpack the files from*.gem
to/usr/lib64/ruby...
and compress that to an RPM). It just makes the submission much longer (1min -> 3mins).Additional Changes
--local
option when building the Ruby gem, it is much faster (1sec vs. 15sec) and the generated file is the sameTasks
agama-cli
packagecockpit-agama
packagecockpit-agama-playwright
packagerubygem-agama
package