Fix differing jars reported as identical #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has already occurred in production with jdk updates OBS reports this was supposed to find /usr/share/java/META-INF/MANIFEST.MF differs (ASCII text, with CRLF line terminators)
--- old//usr/share/java/META-INF/MANIFEST.MF 2018-08-03 05:17:59.012783126 +0000
+++ new//usr/share/java/META-INF/MANIFEST.MF 2018-08-03 05:17:59.016783149 +0000
@@ -1,4 +1,4 @@
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.9.10
-Created-By: 10.0.1+10-suse-lp151.2.1-x8664 (Oracle Corporation)
+Created-By: 10.0.1+10-suse-lp151.2.4-x8664 (Oracle Corporation) |
bmwiedemann
commented
Aug 3, 2018
pkg-diff.sh
Outdated
| @@ -572,7 +572,11 @@ check_single_file() | |||
| diff -u old/flist new/flist | |||
| return 1 | |||
| fi | |||
| flist=`grep date new/flist | sed -e 's,.* date ,,'` | |||
| if [ "$UNJAR" = unzip ] ; then | |||
There was a problem hiding this comment.
still buggy - the variable is unset because unjar_l is called in a subprocess (because of the | sort)
because fastjar prints a plain file list
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
because fastjar prints a plain file list