New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmp_rpm_meta to not return 0 on diff #28

Merged
merged 5 commits into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@bmwiedemann
Member

bmwiedemann commented Sep 4, 2018

See it_reports_differing_rpm_tags test for a reproducer

Also includes:

  • required update of a test to Leap 15.0
  • some fixes in other tests
  • added regression test for this bug
  • code cleanup

bmwiedemann added some commits Sep 4, 2018

Make tests pass on Leap-15.0
rpm now uses sha256 instead of md5
to hash file content
Ensure tests fail on error
! true
is handled differently from
false
with bash's set -e
Fix detecting rpm-tag diffs
in the check_all case
we need to accumulate diff results
clarify cmp_rpm_meta code flow
even without check_all, there is no need to look at individual diffs
because there are none overall
Add test for rpm metadata
as a regression test

@olafhering olafhering merged commit b9e3fe5 into openSUSE:master Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment