Fix cmp_rpm_meta to not return 0 on diff #28

bmwiedemann · 2018-09-04T07:53:52Z

See it_reports_differing_rpm_tags test for a reproducer

Also includes:

rpm now uses sha256 instead of md5 to hash file content

! true is handled differently from false with bash's set -e

as a regression test

in the check_all case we need to accumulate diff results

even without check_all, there is no need to look at individual diffs because there are none overall

bmwiedemann added 5 commits September 4, 2018 06:34

Make tests pass on Leap-15.0

52a2879

rpm now uses sha256 instead of md5 to hash file content

Ensure tests fail on error

ad5f944

! true is handled differently from false with bash's set -e

Add test for rpm metadata

d5e83ce

as a regression test

Fix detecting rpm-tag diffs

68ca271

in the check_all case we need to accumulate diff results

clarify cmp_rpm_meta code flow

d87f2f4

even without check_all, there is no need to look at individual diffs because there are none overall

olafhering merged commit b9e3fe5 into openSUSE:master Sep 6, 2018

Conversation