New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased the portus image to include puma #47

Merged
merged 1 commit into from Mar 17, 2017

Conversation

Projects
None yet
2 participants
@mssola
Contributor

mssola commented Mar 17, 2017

Signed-off-by: Miquel Sabaté Solà msabate@suse.com

Rebased the portus image to include puma
Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

mssola added a commit to mssola/Portus that referenced this pull request Mar 17, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

mssola added a commit to mssola/Portus that referenced this pull request Mar 17, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

mssola added a commit to mssola/Portus that referenced this pull request Mar 17, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

mssola added a commit to mssola/Portus that referenced this pull request Mar 17, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

mssola added a commit to mssola/Portus that referenced this pull request Mar 17, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

mssola added a commit to mssola/Portus that referenced this pull request Mar 17, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
* `PORTUS_PUMA_WORKERS`: the amount of Puma workers to be spawned. Defaults to 1.
* `PORTUS_PUMA_MAX_THREADS`: the maximum amount of Puma threads to be
created. Defaults to 1.
* `RAILS_SERVE_STATIC_FILES`: set this to `true` if you want Puma to serve the

This comment has been minimized.

@flavio

flavio Mar 17, 2017

Member

Are these default values enough to handle the case of Portus authenticating against itself (eg: the crono job scanning the contents of the registry). I remember some issues in the past caused by portus being stuck processing only one request at a time.

@flavio

flavio Mar 17, 2017

Member

Are these default values enough to handle the case of Portus authenticating against itself (eg: the crono job scanning the contents of the registry). I remember some issues in the past caused by portus being stuck processing only one request at a time.

This comment has been minimized.

@mssola

mssola Mar 17, 2017

Contributor

Yes for two reasons:

  • The crono job should be executed in another container, see SUSE/Portus#1254
  • Tuning PORTUS_PUMA_WORKERS and PORTUS_PUMA_MAX_THREADS should avoid any blocking issues.
@mssola

mssola Mar 17, 2017

Contributor

Yes for two reasons:

  • The crono job should be executed in another container, see SUSE/Portus#1254
  • Tuning PORTUS_PUMA_WORKERS and PORTUS_PUMA_MAX_THREADS should avoid any blocking issues.

This comment has been minimized.

@flavio

flavio Mar 17, 2017

Member

My question is: wouldn't it be better to provide sane defaults for these environment variables to avoid our users to do the fine tuning?

@flavio

flavio Mar 17, 2017

Member

My question is: wouldn't it be better to provide sane defaults for these environment variables to avoid our users to do the fine tuning?

This comment has been minimized.

@mssola

mssola Mar 17, 2017

Contributor

Note that these defaults come from Portus' side actually 😃 I'll update that there

@mssola

mssola Mar 17, 2017

Contributor

Note that these defaults come from Portus' side actually 😃 I'll update that there

@flavio

This comment has been minimized.

Show comment
Hide comment
@flavio

flavio Mar 17, 2017

Member

Finally 👏

LGTM

Member

flavio commented Mar 17, 2017

Finally 👏

LGTM

@mssola

This comment has been minimized.

Show comment
Hide comment
@mssola

mssola Mar 17, 2017

Contributor

For the reference to the examples directory see the PR SUSE/Portus#1254

Contributor

mssola commented Mar 17, 2017

For the reference to the examples directory see the PR SUSE/Portus#1254

@mssola mssola merged commit a3718d1 into master Mar 17, 2017

@mssola mssola deleted the portus-docker-image branch Mar 17, 2017

mssola added a commit to mssola/Portus that referenced this pull request Mar 23, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

mssola added a commit to mssola/Portus that referenced this pull request Jul 10, 2017

Added an examples directory
These examples uses the image as defined here openSUSE/docker-containers#47,
which contains the latest master.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment