ensure theme builds are reproducible (bsc #1124165) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
reviewed
Feb 5, 2019
themes/openSUSE/Makefile
Outdated
|
|
||
| message: src/main.bin src/gfxboot.cfg help-boot/.ready po/.ready fonts/.ready | ||
| @rm -rf message.dir | ||
| @mkdir message.dir | ||
| perl -p -e 's/^(layout=.*)/$$1,boot/' src/gfxboot.cfg >message.dir/gfxboot.cfg | ||
| perl -p -e 's/^(layout=.*)/$$1,boot/' src/gfxboot.cfg >message |
There was a problem hiding this comment.
Was this intentional? What is the reasoning?
There was a problem hiding this comment.
Good spotting; that's of course nonsense.
Themes contains two cpio archives. Ensure they are identical in each build.
bmwiedemann
approved these changes
Feb 5, 2019
vagrantc
added a commit
to vagrantc/gfxboot
that referenced
this pull request
Jan 3, 2021
Apply fixes for reproducibilty, similar to: openSUSE#35 See also: https://bugs.debian.org/978946 https://tests.reproducible-builds.org/debian/issues/unstable/users_and_groups_in_cpio_archive_issue.html
vagrantc
added a commit
to vagrantc/gfxboot
that referenced
this pull request
Jan 3, 2021
…akefile as a reference time. Similar to fixes applied in other themes: openSUSE#35 See also: https://bugs.debian.org/978946 https://tests.reproducible-builds.org/debian/issues/unstable/timestamps_in_cpio_archive_issue.html
|
I can confirm that this has normalised the mtime of the files. However, the issue that remains is that the order of the files within the themes files is inherited from the underlying filesystem. So we can end up with diffs like: Untested patch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Themes contains two cpio archives. Ensure they are identical in each
build.