Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-12 SP1: Use stdin, not tmp files for passwords (bsc#986971) #162

Merged
merged 2 commits into from Aug 15, 2016
Merged

SLE-12 SP1: Use stdin, not tmp files for passwords (bsc#986971) #162

merged 2 commits into from Aug 15, 2016

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented Jul 14, 2016

Backport to SLE-12 SP1

This backport is easy because both affected classes (SystemCmd and Volume) were unchanged between SP1 and SP2, so the diffs for this fix are identical.

@shundhammer shundhammer changed the title Use stdin, not tmp files for passwords (bsc#986971) SLE-12 SP1: Use stdin, not tmp files for passwords (bsc#986971) Jul 14, 2016
_pfds[0].events = _pfds[1].events = POLLIN;
_pfds[0].events = POLLOUT; // stdin
_pfds[1].events = POLLIN; // stdout
_pfds[2].events = POLLIN; // stderr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it cause mix to mixture stdout and stdin into one stream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that just enables getting notifications when data is available for any of them. The file descriptors still remain separate.

@jreidinger
Copy link
Member

ok, LGTM

@shundhammer shundhammer merged commit 19d9361 into openSUSE:SLE-12-SP1-GA Aug 15, 2016
@shundhammer shundhammer deleted the huha-pipe-systemcmd-12-SP1 branch October 9, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants