Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debian] fails to handle packages with control.tar.xz #395

Closed
suihkulokki opened this issue Oct 18, 2017 · 4 comments
Closed

[Debian] fails to handle packages with control.tar.xz #395

suihkulokki opened this issue Oct 18, 2017 · 4 comments

Comments

@suihkulokki
Copy link
Contributor

@suihkulokki suihkulokki commented Oct 18, 2017

Builds in debian unstable, using dpkg >= 1.19 will fail in the end with:

[  114s] r2-a19 finished "build hello_2.10-1+deb9u1.dsc" at Wed Oct 18 06:09:11 UTC 2017.
[  114s] 
hello-dbgsym_2.10-1+deb9u1_arm64.deb: has no hdrmd5
hello_2.10-1+deb9u1_arm64.deb: has no hdrmd5

Using perl to tun queryhdrmd5("hello_2.10-1_amd64.deb") results:
hello_2.10-1_amd64.deb: control.tar.gz is not second ar entry
And ar x hello_2.10-1_amd64.deb results:
control.tar.xz data.tar.xz debian-binary
Build/Deb.pm expects control.tar.gz, while .xz has been possible (but not used) until now. Looking at Deb.pm more closely, does it make sense to just use "dpkg-deb --ctrl-tarfile " instead of the manual parsing of deb file in perl code itself?

suihkulokki added a commit to suihkulokki/obs-build that referenced this issue Oct 19, 2017
Add support for uncompressing and hdrmd5 for XZ compressed
control.tar - default on dpkg >= 1.19. Fixes issue openSUSE#395
suihkulokki added a commit to suihkulokki/obs-build that referenced this issue Oct 19, 2017
Add support for uncompressing and hdrmd5 for XZ compressed
control.tar - default on dpkg >= 1.19. Fixes issue openSUSE#395
@mlschroe
Copy link
Member

@mlschroe mlschroe commented Oct 20, 2017

We can't expect dpkg to be installed, that's why dpkg-deb won't work.

@mlschroe
Copy link
Member

@mlschroe mlschroe commented Oct 20, 2017

(We'll also need to support this in libsolv to make building in OBS work)

@suihkulokki
Copy link
Contributor Author

@suihkulokki suihkulokki commented Oct 20, 2017

I noticed I need to fix build-pkg-deb in obs-build and osc has another place where control.tar.gz is directly referenced..

@mlschroe
Copy link
Member

@mlschroe mlschroe commented Oct 20, 2017

Also merged, thanks! Closing this issue.

@mlschroe mlschroe closed this Oct 20, 2017
dbnicholson referenced this issue in endlessm/obs-build May 22, 2018
Add support for uncompressing and hdrmd5 for XZ compressed
control.tar - default on dpkg >= 1.19. Fixes issue #395

(cherry picked from commit 1ed947b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.