Use at least 2 threads for xz compression #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR openSUSE#11 introduced compression depending on number of available CPUs, but xz then produces different output on 1-core-VMs: for n in 2 3 ; do echo | taskset $n xz --threads=0 -c - | md5sum ; done See https://reproducible-builds.org/ for why this matters.
|
okay, still thinking this is a bug in xz in first place then though. But let's apply this workaround for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR #11 introduced compression depending on number of available CPUs,
but xz then produces different output on 1-core-VMs as seen with:
for n in 2 3 ; do echo | taskset $n xz --threads=0 -c - | md5sum ; doneSee https://reproducible-builds.org/ for why this matters.
Edit: also discussing better solutions upstream: https://www.mail-archive.com/xz-devel@tukaani.org/msg00375.html