Skip to content
This repository has been archived by the owner. It is now read-only.

Link headings in infobox to their origin #128

Closed

Conversation

@krauselukas
Copy link
Collaborator

krauselukas commented Jan 26, 2018

No description provided.

@@ -12,7 +12,7 @@
= empties.sort.join(' – ').html_safe
%p Backlog:
%p= link_to "Backlog:", main_app.group_show_path(title: "factory-staging")

This comment has been minimized.

Copy link
@krauselukas

krauselukas Jan 26, 2018

Author Collaborator

still try to find out how to directly filter the right target project in the linked view, but merging won't hurt

This comment has been minimized.

Copy link
@coolo

coolo Jan 29, 2018

Member

don't hardcode factory-staging here - this only applies to opensuse

Copy link
Contributor

jberry-suse left a comment

Nice.

@@ -11,8 +11,11 @@
- else
= empties.sort.join(' – ').html_safe
%p= link_to "Backlog:", main_app.group_show_path(title: "factory-staging")
- case @distribution.name

This comment has been minimized.

Copy link
@krauselukas

krauselukas Feb 12, 2018

Author Collaborator

@coolo Not sure if that is the appropriate way to check if its opensuse, but i couldn't spot another solution

This comment has been minimized.

Copy link
@coolo

coolo Feb 12, 2018

Member

then add a flag in the distribution - this is for the model to decide not the view

@krauselukas

This comment has been minimized.

Copy link
Collaborator Author

krauselukas commented Mar 5, 2018

@coolo could you please check if my PR's are mergeable :)

@coolo

This comment has been minimized.

Copy link
Member

coolo commented Mar 5, 2018

it's not. when I initially said "don't hardcode factory-staging" I meant to use @distribution.staging_manager - your check on name adds even more hardcoding.

I'll finish this so you can concentrate on your new team

@coolo coolo closed this Mar 5, 2018
@coolo coolo reopened this Mar 5, 2018
@coolo

This comment has been minimized.

Copy link
Member

coolo commented Mar 5, 2018

pushed as 70ec734

@coolo coolo closed this Mar 5, 2018
@krauselukas

This comment has been minimized.

Copy link
Collaborator Author

krauselukas commented Mar 5, 2018

@coolo thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.