[api] make sure we validate the XML response if configured

src/api/app/controllers/application_controller.rb

@@ -33,7 +33,7 @@ class ApplicationController < ActionController::Base
   @http_user = nil
 
   before_filter :validate_xml_request, :add_api_version
-  if defined?( RESPONSE_SCHEMA_VALIDATION ) && RESPONSE_SCHEMA_VALIDATION == true
+  if CONFIG['response_schema_validation'] == true
     after_filter :validate_xml_response
   end
 

src/api/config/environments/development.rb

@@ -69,7 +69,7 @@
 CONFIG['extended_backend_log'] = true
 YMP_URL='http://software.opensuse.org/ymp'
 
-RESPONSE_SCHEMA_VALIDATION = true
+CONFIG['response_schema_validation'] = true
 
 require 'socket'
 fname = "#{Rails.root}/config/environments/development.#{Socket.gethostname}.rb"

src/api/config/environments/production.rb

@@ -127,7 +127,7 @@
 #end
 
 # disabled on production for performance reasons
-# RESPONSE_SCHEMA_VALIDATION = true
+# CONFIG['response_schema_validation'] = true
 
 #require 'memory_debugger'
 # dumps the objects after every request

src/api/config/environments/production_test.rb

@@ -48,4 +48,4 @@
   hermesconf.dbname = 'hermes'
 end
 
-RESPONSE_SCHEMA_VALIDATION = true
+CONFIG['response_schema_validation'] = true

src/api/config/environments/stage.rb

@@ -40,4 +40,4 @@
 
 ActionController::AbstractRequest.relative_url_root = "/stage"
 
-RESPONSE_SCHEMA_VALIDATION = true
+CONFIG['response_schema_validation'] = true

src/api/config/environments/test.rb

@@ -47,5 +47,5 @@
 # Max number of times to attempt to contact the LDAP servers
 MAX_LDAP_ATTEMPTS = 10
 
-RESPONSE_SCHEMA_VALIDATION = true
+CONFIG['response_schema_validation'] = true
 

src/api/config/options.yml.example

@@ -34,3 +34,6 @@ new_user_registration: allow
 # Minimum count of rating votes a project/package needs to # be taken in account
 # for global statistics:
 min_votes_for_rating: 3
+
+# Set to true to verify XML reponses comply to the schema
+response_schema_validation: false

src/api/lib/opensuse/validator.rb

@@ -49,7 +49,7 @@ def validate_xml_request
 
     # This method should be called in the ApplicationController of your Rails app.
     def validate_xml_response
-      if request.format != "json" && response.status.to_s == "200 OK" && response.headers['Content-Type'] !~ /.*\/json/i
+      if request.format != "json" && response.status.to_s[0..2] == "200" && response.headers['Content-Type'] !~ /.*\/json/i && response.headers["Content-Disposition"] != "attachment"
         opt = params()
         opt[:method] = request.method.to_s
         opt[:type] = "response"