From 3e17c6bc680d57d07b51719be5b9aff20b0114b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ana=20Mar=C3=ADa=20Mart=C3=ADnez=20G=C3=B3mez?= Date: Mon, 6 Mar 2017 16:35:12 +0100 Subject: [PATCH] [ci] Enable Rails/Exit Rubocop cop --- src/api/.rubocop.yml | 6 ++++++ src/api/.rubocop_todo.yml | 10 ---------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/api/.rubocop.yml b/src/api/.rubocop.yml index 0e0c254684d..1a88bdd332e 100644 --- a/src/api/.rubocop.yml +++ b/src/api/.rubocop.yml @@ -222,6 +222,12 @@ Performance/StringReplacement: Rails: Enabled: true + +# Enforces that 'exit' calls are not used. +Rails/Exit: + Exclude: + - 'lib/memory_dumper.rb' + - 'config/deploy.rb' # Use `find_by` instead `where.first` and `where.take` Rails/FindBy: diff --git a/src/api/.rubocop_todo.yml b/src/api/.rubocop_todo.yml index 0a568df8bcd..ef174dc3715 100644 --- a/src/api/.rubocop_todo.yml +++ b/src/api/.rubocop_todo.yml @@ -133,16 +133,6 @@ Performance/CompareWithBlock: Rails/DynamicFindBy: Enabled: false -# Offense count: 4 -# Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb -Rails/Exit: - Exclude: - - 'lib/**/*.rake' - - 'app/jobs/consistency_check.rb' - - 'config/deploy.rb' - - 'lib/memory_dumper.rb' - # Offense count: 126 Rails/FilePath: Enabled: false