From 468a705b8e3f36aa0f5ea1fa6c7a49805cd97c29 Mon Sep 17 00:00:00 2001 From: Eduardo Navarro Date: Mon, 4 Jun 2018 15:36:53 +0200 Subject: [PATCH] [webui] Move non-action methods to private section --- .../controllers/webui/patchinfo_controller.rb | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/api/app/controllers/webui/patchinfo_controller.rb b/src/api/app/controllers/webui/patchinfo_controller.rb index 5e8939d3509..8e35a836a12 100644 --- a/src/api/app/controllers/webui/patchinfo_controller.rb +++ b/src/api/app/controllers/webui/patchinfo_controller.rb @@ -220,15 +220,6 @@ def delete_dialog render_dialog end - def valid_summary?(name) - name && name.length > 10 - end - - def valid_description?(name) - name && - name.length > [params[:summary].length, 50].max - end - def new_tracker # collection with all informations of the new issues issue_collection = [] @@ -274,6 +265,17 @@ def new_tracker render json: { error: error, issues: issue_collection } end + private + + def valid_summary?(name) + name && name.length > 10 + end + + def valid_description?(name) + name && + name.length > [params[:summary].length, 50].max + end + # returns issue summary of an issue # returns empty string in case of ActiveXML::Transport::Error exception # returns nil in case of error (bug mismatches tracker result regex) @@ -294,8 +296,6 @@ def get_issue_sum(tracker, issueid) return '' end - private - def get_binaries @binarylist = [] binary_list = Buildresult.find(project: params[:project], view: 'binarylist')