From 81348c149b3aef94122a0455a28f44e1339bf767 Mon Sep 17 00:00:00 2001 From: Eduardo Navarro Date: Wed, 13 Dec 2023 14:17:42 +0100 Subject: [PATCH] Regenerate RuboCop TODO file for rails subdirectory --- src/api/.rubocop_todo.yml | 52 ++++++++++++++++++++------------------- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/src/api/.rubocop_todo.yml b/src/api/.rubocop_todo.yml index 524b146d32a..36668dcd4ba 100644 --- a/src/api/.rubocop_todo.yml +++ b/src/api/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100` -# on 2023-11-03 11:42:38 UTC using RuboCop version 1.57.2. +# on 2023-12-13 13:14:58 UTC using RuboCop version 1.59.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -126,7 +126,7 @@ Lint/UselessMethodDefinition: - 'app/controllers/webui/requests/submissions_controller.rb' - 'test/test_helper.rb' -# Offense count: 894 +# Offense count: 892 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 256 @@ -233,7 +233,7 @@ Metrics/ClassLength: - 'test/unit/publish_flag_test.rb' - 'test/unit/user_test.rb' -# Offense count: 190 +# Offense count: 188 # Configuration parameters: AllowedMethods, AllowedPatterns, Max. Metrics/CyclomaticComplexity: Exclude: @@ -324,7 +324,7 @@ Metrics/CyclomaticComplexity: - 'test/functional/zzz_post_consistency_test.rb' - 'test/node_matcher.rb' -# Offense count: 978 +# Offense count: 975 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 221 @@ -357,7 +357,7 @@ Metrics/ParameterLists: - 'test/functional/read_permission_test.rb' - 'test/functional/source_controller_test.rb' -# Offense count: 164 +# Offense count: 162 # Configuration parameters: AllowedMethods, AllowedPatterns, Max. Metrics/PerceivedComplexity: Exclude: @@ -487,7 +487,7 @@ Naming/MethodName: - 'test/functional/search_controller_test.rb' - 'test/test_helper.rb' -# Offense count: 50 +# Offense count: 30 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. # AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to Naming/MethodParameterName: @@ -605,20 +605,20 @@ RSpec/AnyInstance: - 'spec/models/project_spec.rb' - 'spec/policies/package_policy_spec.rb' -# Offense count: 1274 +# Offense count: 1283 # Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: Enabled: false -# Offense count: 477 +# Offense count: 472 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SkipBlocks, EnforcedStyle. # SupportedStyles: described_class, explicit RSpec/DescribedClass: Enabled: false -# Offense count: 215 +# Offense count: 217 # Configuration parameters: Max, CountAsOne. RSpec/ExampleLength: Exclude: @@ -661,7 +661,6 @@ RSpec/ExampleLength: - 'spec/features/webui/users/user_home_page_spec.rb' - 'spec/features/webui/watchlists_spec.rb' - 'spec/helpers/webui/markdown_helper_spec.rb' - - 'spec/helpers/webui/webui_helper_spec.rb' - 'spec/lib/rubocop/cop/view_component/avoid_global_state_spec.rb' - 'spec/lib/rubocop/cop/view_component/class_name_spec.rb' - 'spec/lib/rubocop/cop/view_component/file_name_spec.rb' @@ -725,7 +724,7 @@ RSpec/IteratedExpectation: Exclude: - 'spec/models/user_spec.rb' -# Offense count: 385 +# Offense count: 383 # This cop supports safe autocorrection (--autocorrect). RSpec/LeadingSubject: Enabled: false @@ -765,7 +764,7 @@ RSpec/MessageSpies: - 'spec/controllers/webui/apidocs_controller_spec.rb' - 'spec/models/kiwi/image_spec.rb' -# Offense count: 1707 +# Offense count: 1709 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: Max: 28 @@ -825,7 +824,7 @@ Rails/CreateTableWithTimestamps: Exclude: - 'db/migrate/20171030143054_create_kiwi_preference_types.rb' -# Offense count: 74 +# Offense count: 71 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments @@ -859,7 +858,7 @@ Rails/FilePath: - 'test/functional/zzz_post_consistency_test.rb' - 'test/test_helper.rb' -# Offense count: 8 +# Offense count: 7 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowedMethods, AllowedPatterns. # AllowedMethods: order, limit, select, lock @@ -897,7 +896,7 @@ Rails/HelperInstanceVariable: - 'app/helpers/webui/project_helper.rb' - 'app/helpers/webui/webui_helper.rb' -# Offense count: 38 +# Offense count: 37 # Configuration parameters: IgnoreScopes, Include. # Include: app/models/**/*.rb Rails/InverseOf: @@ -939,7 +938,7 @@ Rails/OutputSafety: - 'app/helpers/webui/request_helper.rb' - 'app/helpers/webui/user_helper.rb' -# Offense count: 13 +# Offense count: 14 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Include. # Include: **/Rakefile, **/*.rake @@ -1037,7 +1036,10 @@ Rails/TimeZone: # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowOnlyRestArgument, UseAnonymousForwarding. +# Configuration parameters: AllowOnlyRestArgument, UseAnonymousForwarding, RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, RedundantBlockArgumentNames. +# RedundantRestArgumentNames: args, arguments +# RedundantKeywordRestArgumentNames: kwargs, options, opts +# RedundantBlockArgumentNames: blk, block, proc Style/ArgumentsForwarding: Exclude: - 'app/models/configuration.rb' @@ -1085,7 +1087,7 @@ Style/ConditionalAssignment: Exclude: - 'app/models/bs_request_action_submit.rb' -# Offense count: 1036 +# Offense count: 1055 # Configuration parameters: AllowedConstants. Style/Documentation: Enabled: false @@ -1097,7 +1099,7 @@ Style/ExplicitBlockArgument: - 'app/lib/backend/connection.rb' - 'app/models/project.rb' -# Offense count: 1795 +# Offense count: 1815 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -1162,7 +1164,7 @@ Style/OpenStructUse: - 'spec/services/trigger_controller_service/token_extractor_spec.rb' - 'spec/services/webui_controller_service/user_checker_spec.rb' -# Offense count: 22 +# Offense count: 21 # Configuration parameters: AllowedMethods. # AllowedMethods: respond_to_missing? Style/OptionalBooleanParameter: @@ -1193,21 +1195,21 @@ Style/SlicingWithRange: - 'app/services/package_service/schema_verifier.rb' - 'test/node_matcher.rb' -# Offense count: 384 +# Offense count: 385 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinSize. # SupportedStyles: percent, brackets Style/SymbolArray: EnforcedStyle: brackets -# Offense count: 304 +# Offense count: 299 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize, WordRegex. # SupportedStyles: percent, brackets Style/WordArray: Enabled: false -# Offense count: 9 +# Offense count: 10 ViewComponent/AvoidGlobalState: Exclude: - 'app/components/bs_request_activity_timeline_component.rb' @@ -1215,7 +1217,7 @@ ViewComponent/AvoidGlobalState: - 'app/components/notification_filter_component.rb' - 'app/components/user_avatar_component.rb' -# Offense count: 26 +# Offense count: 25 ViewComponent/MissingPreviewFile: Exclude: - 'app/components/action_seen_by_user_component.rb' @@ -1244,7 +1246,7 @@ ViewComponent/MissingPreviewFile: - 'app/components/workflow_run_row_component.rb' - 'app/components/workflow_run_status_badge_component.rb' -# Offense count: 2798 +# Offense count: 3286 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https