From b602fd358ea4e5b900978bbf6ecfaa300af68108 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 19 Oct 2015 15:11:20 +0200 Subject: [PATCH] [webui] Reintroduce test for not_existing_target Fixed #1269 --- src/api/test/functional/request_controller_test.rb | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/api/test/functional/request_controller_test.rb b/src/api/test/functional/request_controller_test.rb index dc5e6d246d5..63253efad17 100644 --- a/src/api/test/functional/request_controller_test.rb +++ b/src/api/test/functional/request_controller_test.rb @@ -2477,12 +2477,19 @@ def test_branch_and_submit_request_to_linked_project_and_delete_it_again assert_xml_tag(:parent => { tag: 'revision' }, :tag => 'comment', :content => 'DELETE REQUEST') assert_xml_tag(:parent => { tag: 'revision' }, :tag => 'requestid', :content => id) - # accept the other request, what will fail login_king + # you can only accept request in state new post "/request/#{id2}?cmd=changestate&newstate=accepted&force=1" assert_response 403 assert_xml_tag(:tag => 'status', :attributes => { code: 'post_request_no_permission' }) + # you can only accept request in state new and with an existing target + post "/request/#{id2}?cmd=changestate&newstate=new&force=1" + assert_response :success + post "/request/#{id2}?cmd=changestate&newstate=accepted&force=1" + assert_response 404 + assert_xml_tag(:tag => 'status', :attributes => { code: 'not_existing_target' }) + # decline the request post "/request/#{id2}?cmd=changestate&newstate=declined" assert_response :success