From 2655df7c80fe516b86e6cf352e05e9c612d0f4d0 Mon Sep 17 00:00:00 2001
From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com>
Date: Sun, 12 Sep 2021 02:46:42 +0000
Subject: [PATCH 1/2] Update rubocop-rails to version 2.12.2

---
 src/api/Gemfile.lock | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/api/Gemfile.lock b/src/api/Gemfile.lock
index 995dedca9f1..0fca7dad4aa 100644
--- a/src/api/Gemfile.lock
+++ b/src/api/Gemfile.lock
@@ -394,7 +394,7 @@ GEM
     rubocop-performance (1.11.5)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.11.3)
+    rubocop-rails (2.12.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)

From 645148f6945e73ecbf8f04ba5ec07317fa6c345b Mon Sep 17 00:00:00 2001
From: Rubhan Azeem <rubhanazeem@gmail.com>
Date: Wed, 15 Sep 2021 16:09:22 +0200
Subject: [PATCH 2/2] Update rubocop todo

---
 src/api/.rubocop_todo.yml | 31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)

diff --git a/src/api/.rubocop_todo.yml b/src/api/.rubocop_todo.yml
index 0a0b9e7f2b1..d70851aa588 100644
--- a/src/api/.rubocop_todo.yml
+++ b/src/api/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2021-08-17 14:00:34 UTC using RuboCop version 1.19.0.
+# on 2021-09-15 13:59:50 UTC using RuboCop version 1.20.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -232,7 +232,7 @@ Metrics/ClassLength:
     - 'test/unit/publish_flag_test.rb'
     - 'test/unit/user_test.rb'
 
-# Offense count: 192
+# Offense count: 191
 # Configuration parameters: IgnoredMethods, Max.
 Metrics/CyclomaticComplexity:
   Exclude:
@@ -339,12 +339,11 @@ Metrics/ModuleLength:
     - 'app/mixins/has_attributes.rb'
     - 'app/mixins/has_relationships.rb'
 
-# Offense count: 18
+# Offense count: 16
 # Configuration parameters: Max, CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Exclude:
     - 'app/helpers/maintenance_helper.rb'
-    - 'app/lib/backend/api/build_results/job_history.rb'
     - 'app/lib/backend/api/build_results/status.rb'
     - 'app/lib/backend/api/sources/package.rb'
     - 'app/lib/backend/logger.rb'
@@ -353,9 +352,8 @@ Metrics/ParameterLists:
     - 'lib/statistics_calculations.rb'
     - 'test/functional/read_permission_test.rb'
     - 'test/functional/source_controller_test.rb'
-    - 'test/test_helper.rb'
 
-# Offense count: 166
+# Offense count: 165
 # Configuration parameters: IgnoredMethods, Max.
 Metrics/PerceivedComplexity:
   Exclude:
@@ -669,7 +667,7 @@ RSpec/AnyInstance:
     - 'spec/models/project_spec.rb'
     - 'spec/policies/package_policy_spec.rb'
 
-# Offense count: 911
+# Offense count: 938
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -683,7 +681,7 @@ RSpec/DescribeClass:
     - 'spec/routing/webui/projects/public_key_spec.rb'
     - 'spec/routing/webui/projects/ssl_certificate_spec.rb'
 
-# Offense count: 435
+# Offense count: 433
 # Cop supports --auto-correct.
 # Configuration parameters: SkipBlocks, EnforcedStyle.
 # SupportedStyles: described_class, explicit
@@ -791,7 +789,7 @@ RSpec/MessageSpies:
     - 'spec/controllers/webui/apidocs_controller_spec.rb'
     - 'spec/models/kiwi/image_spec.rb'
 
-# Offense count: 1429
+# Offense count: 1420
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 27
@@ -908,13 +906,14 @@ Rails/FilePath:
     - 'test/functional/zzz_post_consistency_test.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 23
+# Offense count: 27
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/HasManyOrHasOneDependent:
   Exclude:
     - 'app/models/architecture.rb'
     - 'app/models/attrib.rb'
+    - 'app/models/bs_request.rb'
     - 'app/models/package.rb'
     - 'app/models/project.rb'
     - 'app/models/repository.rb'
@@ -1095,7 +1094,7 @@ Style/ConditionalAssignment:
   Exclude:
     - 'app/models/bs_request_action_submit.rb'
 
-# Offense count: 711
+# Offense count: 712
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
@@ -1107,7 +1106,7 @@ Style/ExplicitBlockArgument:
     - 'app/lib/backend/connection.rb'
     - 'app/models/project.rb'
 
-# Offense count: 1474
+# Offense count: 1481
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -1184,27 +1183,27 @@ Style/SoleNestedConditional:
     - 'script/reformat_memprof'
     - 'test/node_matcher.rb'
 
-# Offense count: 301
+# Offense count: 299
 # Cop supports --auto-correct.
 # Configuration parameters: Mode.
 Style/StringConcatenation:
   Enabled: false
 
-# Offense count: 339
+# Offense count: 342
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
 Style/SymbolArray:
   EnforcedStyle: brackets
 
-# Offense count: 249
+# Offense count: 248
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinSize, WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
   Enabled: false
 
-# Offense count: 1952
+# Offense count: 1956
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https