From 71a2a434b7158fa882e736b473c81632394c2f71 Mon Sep 17 00:00:00 2001 From: Lukas Krause Date: Thu, 13 Sep 2018 18:59:29 +0200 Subject: [PATCH] Do not return image tag if no_icon var is set The no_icon variable had no effect Fixes #4926 --- src/api/app/helpers/webui/user_helper.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/api/app/helpers/webui/user_helper.rb b/src/api/app/helpers/webui/user_helper.rb index b1e7b7c532d..b61d3194caf 100644 --- a/src/api/app/helpers/webui/user_helper.rb +++ b/src/api/app/helpers/webui/user_helper.rb @@ -67,7 +67,11 @@ def user_with_realname_and_icon(user, opts = {}) printed_name = "#{realname} (#{user.login})" end - user_image_tag(user) + ' ' + link_to(printed_name, user_show_path(user)) + if opts[:no_icon] + link_to(printed_name, user_show_path(user)) + else + user_image_tag(user) + ' ' + link_to(printed_name, user_show_path(user)) + end end end