Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation dialog is not shown while removing a Member from a Group #10316

Closed
OleksandrOrlov opened this issue Oct 16, 2020 · 0 comments · Fixed by #10391
Closed

Confirmation dialog is not shown while removing a Member from a Group #10316

OleksandrOrlov opened this issue Oct 16, 2020 · 0 comments · Fixed by #10391
Labels
Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution

Comments

@OleksandrOrlov
Copy link
Contributor

There is no confirmation dialog while clicking on "X" button to remove a Member from a Group. All destructive actions should require confirmation to prevent user errors.

Steps to reproduce:

  1. Log in as Admin;
  2. Create new group if there is no one yet (Configuration->Manage Groups->Create Group);
  3. Go to Group Members Page for the recently created group (e.g. by clicking on its title in the list);
  4. Press "+" button to add new member;
  5. Click "x" icon on the Member's tile to remove the Member.

Expected result:
Confirmation Dialog is shown.
Actual result:
User is removed without any confirmations.

The comments deletion and status message deletion should be the closest ones in terms of implementation.

@OleksandrOrlov OleksandrOrlov added Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution labels Oct 16, 2020
jcronenberg added a commit to jcronenberg/open-build-service that referenced this issue Nov 4, 2020
jcronenberg added a commit to jcronenberg/open-build-service that referenced this issue Nov 4, 2020
jcronenberg added a commit to jcronenberg/open-build-service that referenced this issue Nov 4, 2020
jcronenberg added a commit to jcronenberg/open-build-service that referenced this issue Nov 5, 2020
Fixes openSUSE#10316

Fix groups testcases to work with confirmation dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant