Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM/CI link_package + services #14431

Closed
hennevogel opened this issue Jun 2, 2023 · 0 comments · Fixed by #14437
Closed

SCM/CI link_package + services #14431

hennevogel opened this issue Jun 2, 2023 · 0 comments · Fixed by #14437
Assignees
@hennevogel
Labels
Bug Frontend Things related to the OBS RoR app P2 If possible, assign this to yourself and fix it ASAP scm-ci Things related to the scm-ci feature

Comments

@hennevogel
Copy link
Member

The backend changed how it decides if service should run for a package. Services in modes that would not run server side are filtered out a while ago.

We used a project wide service in localonly to "trick" the backend into running services for linked packages in the link_package step.

open-build-service/src/api/app/models/workflow/step/link_package_step.rb

Lines 75 to 81 in 672cbc7

def special_package_file_content
<<~XML
<services>
<service name="format_spec_file" mode="localonly"/>
</services>
XML
end

This stopped working a while ago, hence services are not running anymore for packages created with the link_package step. Which makes them kind of useless for PR events where it's supposed to run the services to pick up changes from the PR...
@hennevogel hennevogel added Bug Frontend Things related to the OBS RoR app scm-ci Things related to the scm-ci feature P2 If possible, assign this to yourself and fix it ASAP labels Jun 2, 2023
@hennevogel hennevogel self-assigned this Jun 2, 2023
@hennevogel hennevogel mentioned this issue Jun 2, 2023
Merged
2 tasks
hennevogel added a commit to hennevogel/open-build-service that referenced this issue Aug 4, 2023
@hennevogel
Move _branch_request file related things
eb8c0bb 
to the step where they are used. This has been in Step
because we used to use this in link_package too but that
is gone since openSUSE#14431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hennevogel hennevogel

Labels
Bug Frontend Things related to the OBS RoR app P2 If possible, assign this to yourself and fix it ASAP scm-ci Things related to the scm-ci feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop trying to run services for link_package step hennevogel/open-build-service
1 participant
@hennevogel