Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

remove css height declaration from CodeMirror #213

Closed
yaccz opened this Issue · 11 comments

3 participants

@yaccz

No description provided.

@adrianschroeter

why?

closing since no reason given

@yaccz

Because with it, the editor takes only 1/3 of my monitor height with 2/3 useless.
Without this declaration the editor adjusts to the height of browser window.

@yaccz

perhaps a picture will help you understand this complex problem.

kek

@coolo
Owner

it adjusts to the size of the document actually

@coolo coolo reopened this
@yaccz

it adjusts to the size of the document actually

whaaa? Do you see the scrollbar?

@coolo
Owner

without height it's not going with the browser height but with the document height

@yaccz

What do you mean by document?

I just know the height is capped at some silly number like 527px and if I remove it in the inspector thing or what's it called, it will adjust to the height of the viewport if the document is that long.

@yaccz

Also there is something called min-height, for like a decade and half or so if you haven't noticed yet.

@yaccz

Ok, I see your point. Apparently I remember the behaviour incorrectly. Making it fit into the viewport will need more css trickery but I don't care for that. At least in read-only mode I think stretching to document height is not really different than stretching to the 100% of viewport.

@coolo
Owner

I don't actually remember changing it, but it no longer applies to build.opensuse.org

@coolo coolo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.