Skip to content

remove css height declaration from CodeMirror #213

Closed
yaccz opened this Issue Mar 5, 2013 · 11 comments

3 participants

@yaccz
yaccz commented Mar 5, 2013

No description provided.

@adrianschroeter
The openSUSE Project member

why?

closing since no reason given

@yaccz
yaccz commented May 16, 2013

Because with it, the editor takes only 1/3 of my monitor height with 2/3 useless.
Without this declaration the editor adjusts to the height of browser window.

@yaccz
yaccz commented Jun 27, 2013

perhaps a picture will help you understand this complex problem.

kek

@coolo
The openSUSE Project member
coolo commented Jun 27, 2013

it adjusts to the size of the document actually

@coolo coolo reopened this Jun 27, 2013
@coolo
The openSUSE Project member
coolo commented Jun 27, 2013
@yaccz
yaccz commented Jun 27, 2013

it adjusts to the size of the document actually

whaaa? Do you see the scrollbar?

@coolo
The openSUSE Project member
coolo commented Jun 27, 2013

without height it's not going with the browser height but with the document height

@yaccz
yaccz commented Jun 27, 2013

What do you mean by document?

I just know the height is capped at some silly number like 527px and if I remove it in the inspector thing or what's it called, it will adjust to the height of the viewport if the document is that long.

@yaccz
yaccz commented Jun 27, 2013

Also there is something called min-height, for like a decade and half or so if you haven't noticed yet.

@yaccz
yaccz commented Jun 27, 2013

Ok, I see your point. Apparently I remember the behaviour incorrectly. Making it fit into the viewport will need more css trickery but I don't care for that. At least in read-only mode I think stretching to document height is not really different than stretching to the 100% of viewport.

@coolo
The openSUSE Project member
coolo commented Nov 14, 2013

I don't actually remember changing it, but it no longer applies to build.opensuse.org

@coolo coolo closed this Nov 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.