bs_srcserver: configurable vendorname #157

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@cschneemann
Contributor

Make the vendortag set by srcserver configurable through new variable
in BSConfig.pm.

If variable is not set (default) the current "obs://$obsname/$vprojid"

@cschneemann cschneemann bs_srcserver: configurable vendorname
Make the vendortag set by srcserver configurable through new variable
in BSConfig.pm.

If variable is not set (default) the current "obs://$obsname/$vprojid"
9bcc355
@coolo
Member
coolo commented on 9bcc355 Dec 21, 2012

hmm, wouldn't it make sense to put things like that in the API /configuration and have that upload to the backend? And support %obsname and stuff in there?

Just an idea - pretty much unrelated to your very change

Member

The problem which I see in this implementation is that it is not possible to make it configurable per project or to extend the current string.

I think you should just use

our $extramacros = {
'^Your:PROJECT$' => "%vendor YOUR STRING\n",
}

Is that sufficient for you ?

extramacros does exactly what is needed. So the change in this pull request is not needed.

@adrianschroeter
Member

okay, great, closing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment