New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webui][api] Add references to BsRequestAction #3100

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
3 participants
@ChrisBr
Copy link
Member

ChrisBr commented May 10, 2017

for target_package, target_project and source_package and source_project.
To refactor code and improve ActiveRecord queries.

[webui][api] Add references to BsRequestAction
for target_package, target_project and source_package and source_project.
To refactor code and improve ActiveRecord queries.

@ChrisBr ChrisBr force-pushed the ChrisBr:bs_request_action_assocations branch from db56aee to 4f63a4d May 10, 2017

@ChrisBr

This comment has been minimized.

Copy link
Member

ChrisBr commented May 10, 2017

Migration took ~190 seconds for build.o.o

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 10, 2017

Codecov Report

Merging #3100 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
+ Coverage   88.83%   88.84%   +0.01%     
==========================================
  Files         262      262              
  Lines       17588    17606      +18     
==========================================
+ Hits        15624    15642      +18     
  Misses       1964     1964
Flag Coverage Δ
#api 83.62% <100%> (+0.02%) ⬆️
#rspec 65.72% <100%> (+0.02%) ⬆️
#webui 63.51% <100%> (-0.98%) ⬇️
@bgeuken
Copy link
Member

bgeuken left a comment

Seems to be fine to me. Good job!

@hennevogel hennevogel merged commit 2c5d7f6 into openSUSE:master May 11, 2017

4 checks passed

Hakiri No security warnings were found.
Details
codecov/patch 100% of diff hit (target 88.83%)
Details
codecov/project 88.84% (+0.01%) compared to 13c8db7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChrisBr ChrisBr deleted the ChrisBr:bs_request_action_assocations branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment