New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webui][api] Refactor User#declined_requests #3107

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
2 participants
@ChrisBr
Copy link
Member

ChrisBr commented May 11, 2017

and use ActiveRecord associations instead of BsRequest#collection.

creator: admin_user)
}

let(:subject) { confirmed_user.declined_requests }

This comment has been minimized.

@bgeuken

bgeuken May 11, 2017

Member

Seems the "right" way would be to wrap it like this: subject { ... }

@bgeuken

This comment has been minimized.

Copy link
Member

bgeuken commented May 11, 2017

LGTM

[webui][api] Refactor User#declined_requests
and use ActiveRecord associations instead of BsRequest#collection.

@ChrisBr ChrisBr force-pushed the ChrisBr:declined_requests branch from 322da41 to edded4f May 11, 2017

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 11, 2017

Codecov Report

Merging #3107 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
+ Coverage   88.91%   88.91%   +<.01%     
==========================================
  Files         262      262              
  Lines       17606    17606              
==========================================
+ Hits        15654    15655       +1     
+ Misses       1952     1951       -1
Flag Coverage Δ
#api 83.64% <33.33%> (-0.01%) ⬇️
#rspec 65.81% <100%> (ø) ⬆️
#webui 64.54% <100%> (+0.01%) ⬆️

@ChrisBr ChrisBr merged commit b26d953 into openSUSE:master May 11, 2017

4 checks passed

Hakiri No security warnings were found.
Details
codecov/patch 100% of diff hit (target 88.91%)
Details
codecov/project 88.91% (+<.01%) compared to 2c5d7f6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChrisBr ChrisBr deleted the ChrisBr:declined_requests branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment