New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test revision handling in PackageController#show #3115

Merged
merged 3 commits into from May 18, 2017

Conversation

Projects
None yet
3 participants
@hennevogel
Copy link
Member

hennevogel commented May 16, 2017

Supersedes #3080

bgeuken and others added some commits May 5, 2017

[webui] Throw an exception for not existing revisions
ActiveXML::Node.find will just say nothing if the project,
package or revision does not exist. That made set_file_details
always pass and return an empty @file array.
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 16, 2017

Codecov Report

Merging #3115 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
+ Coverage   88.89%   88.91%   +0.01%     
==========================================
  Files         263      263              
  Lines       17596    17594       -2     
==========================================
+ Hits        15642    15643       +1     
+ Misses       1954     1951       -3
Flag Coverage Δ
#api 84.42% <ø> (ø) ⬆️
#rspec 65.34% <100%> (-0.43%) ⬇️
#webui 64.23% <100%> (+0.3%) ⬆️
@Ana06
Copy link
Member

Ana06 left a comment

LGTM, although the cassettes in the second commit are there in porpouse? Because if you didn't chabge any test, I would expect the cassettes to remain the same

@hennevogel

This comment has been minimized.

Copy link
Member

hennevogel commented May 17, 2017

Every package#show now makes a different request to the backend.

@bgeuken

This comment has been minimized.

Copy link
Member

bgeuken commented May 18, 2017

If the second commit cleans up the previous one, I would squash them together

@bgeuken
Copy link
Member

bgeuken left a comment

Tried it out and seems to work. LGTM👍

@hennevogel hennevogel merged commit f660697 into openSUSE:master May 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hennevogel hennevogel deleted the hennevogel:bgeuken-package_rev branch Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment