New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and test codemirror editor in WebuiHelper #3119

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
3 participants
@Ana06
Copy link
Member

Ana06 commented May 18, 2017

Remove #setup_codemirror_editor method and introduce #codemirror_style method instead to have all the head_style parameters code separated in one method.

Also, add test for #codemirror_style.

The code can also be refactor more, but the testing part that was the main goal of this PR is working. :bowtie:

Supersedes #3102

Refactor and test codemirror editor in WebuiHelper
Remove `#setup_codemirror_editor` method and introduce
`#codemirror_style` method instead to have all the `head_style`
parameters code separated in one method.

Also, add test for `#codemirror_style`.

@Ana06 Ana06 added the Frontend 👻 label May 18, 2017

@Ana06

This comment has been minimized.

Copy link
Member

Ana06 commented May 18, 2017

@bgeuken bgeuken merged commit 9242a7b into openSUSE:master May 18, 2017

4 checks passed

Hakiri No security warnings were found.
Details
codecov/patch 100% of diff hit (target 88.92%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +11.07% compared to f660697
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Ana06 Ana06 deleted the Ana06:webui_helper_tests branch Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment