New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor User#outgoing_requests #3158

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
2 participants
@ChrisBr
Copy link
Member

ChrisBr commented May 29, 2017

No description provided.

ChrisBr added some commits May 29, 2017

[webui] Refactor User#outgoing_requests
to use rails associations and improve performance.
[ci] Fix user#declined_requests tests
as they didn't test anything without the Bang.
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 30, 2017

Codecov Report

Merging #3158 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3158      +/-   ##
==========================================
+ Coverage   88.93%   88.93%   +<.01%     
==========================================
  Files         263      263              
  Lines       17590    17591       +1     
==========================================
+ Hits        15643    15644       +1     
  Misses       1947     1947
Flag Coverage Δ
#api 84.45% <0%> (-0.01%) ⬇️
#rspec 65.25% <100%> (-0.64%) ⬇️
#webui 64.22% <100%> (+0.3%) ⬆️

@ChrisBr ChrisBr merged commit 4551061 into openSUSE:master May 30, 2017

4 checks passed

Hakiri No security warnings were found.
Details
codecov/patch 100% of diff hit (target 88.93%)
Details
codecov/project 88.93% (+<.01%) compared to 7e5b51a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChrisBr ChrisBr deleted the ChrisBr:outgoing_requests branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment