[api] Fix payload keys in ServiceSuccess #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the `comment` key from the `payload keys` and added `project` twice instead in `Event::ServiceSucess` when refactoring the `Event` module: #4191
Ana06
added
Frontend
evanrolfe
approved these changes
Dec 14, 2017
DavidKang
approved these changes
Dec 14, 2017
Codecov Report
@@ Coverage Diff @@
## master #4227 +/- ##
==========================================
- Coverage 87.82% 87.79% -0.04%
==========================================
Files 340 340
Lines 18557 18557
==========================================
- Hits 16298 16292 -6
- Misses 2259 2265 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
commentkey from thepayload keysand addedprojecttwice instead inEvent::ServiceSucesswhen refactoring theEventmodule in #4191 馃檲