Handle self-referencing repositories when cloning staging projects #6770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The staging workflow model is creating 2 staging projects by default, *:Staging:A and *:Staging:B. To avoid conflicts, and flickering tests, when using the staging workflow factory, we start naming our factories with *:Staging:C instead of *:Staging:A.
We want to be able to use existing staging projects as template for creating new ones. For that to work we need to be able copy staging projects and a subset of their associations (flags, relationships and repositories). The deep_cloneable gem provides this functionality, which is why we use it here. To be able to deep copy download repositories we had to update the arch validation so that it works with associated data that is not yet saved.
bgeuken
force-pushed
the
clone_staging_projects_with_self_referencing_repos
branch
from
be9d3e1
to
32b147d
Compare
coolo
reviewed
Jan 15, 2019
...i/spec/cassettes/Staging_StagingProject/_copy/copies_the_repositories_and_it_s_relations.yml
Show resolved
Hide resolved
Some staging projects contain repositories that refer to themself. In such cases we create a new self-referencing repository path that references to the matching repository of the newly created project.
bgeuken
force-pushed
the
clone_staging_projects_with_self_referencing_repos
branch
2 times, most recently
from
8ad85b4
to
cae4090
Compare
Automatically rename repository links that reference to repositories within the same project, if their name contains a reference to the project.
bgeuken
force-pushed
the
clone_staging_projects_with_self_referencing_repos
branch
from
cae4090
to
86d4465
Compare
vpereira
approved these changes
Jan 16, 2019
DavidKang
approved these changes
Jan 16, 2019
bgeuken
deleted the
clone_staging_projects_with_self_referencing_repos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6759 (The first two commits).
This adds some code to handle staging projects that contain repositories that link to repositories of the project they belong to. In such cases we now clone the self-referencing link.