Migrate monitor#old to Bootstrap #7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcoux
added
Frontend
|
Review app will appear here: http://obs-reviewlab.opensuse.org/dmarcoux-bootstrap-monitor-old |
Codecov Report
@@ Coverage Diff @@
## master #7672 +/- ##
==========================================
- Coverage 90.72% 90.72% -0.01%
==========================================
Files 499 499
Lines 21376 21360 -16
==========================================
- Hits 19394 19379 -15
+ Misses 1982 1981 -1 |
DavidKang
suggested changes
Jun 4, 2019
src/api/app/views/webui2/webui/monitor/_building_table.html.haml
Outdated
Show resolved
Hide resolved
dmarcoux
force-pushed
the
bootstrap-monitor-old
branch
from
8a7e857
to
d59bb87
Compare
DavidKang
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review, see this comment from @vpereira (thank you!). I find it easier to review locally, but it's also possible in the review app.
Review link: https://obs-reviewlab.opensuse.org/dmarcoux-bootstrap-monitor-old/monitor/old
Please keep in mind that I ported the view with minor changes and fixed most of the Rubocop offenses. I ignored some
InlineStylesoffenses to keep the legend as it is.Before:
Now:
