From 25933f9e999cc96b7b3071cbc3f585f4f5030669 Mon Sep 17 00:00:00 2001
From: Gustavo Yokoyama Ribeiro <gyribeiro@suse.com>
Date: Thu, 18 Apr 2024 09:28:52 -0300
Subject: [PATCH] fix issue #3073

For openSUSE-release-tools-slsa-build-service package create osrt-slsa
user and group using sysusers.d

Move SLSA config files to slsa directory
---
 Makefile                                 |  3 +--
 dist/package/openSUSE-release-tools.spec | 10 +++++++---
 {config => slsa}/logrotate               |  0
 slsa/osrt-slsa-user.conf                 |  2 ++
 4 files changed, 10 insertions(+), 5 deletions(-)
 rename {config => slsa}/logrotate (100%)
 create mode 100644 slsa/osrt-slsa-user.conf

diff --git a/Makefile b/Makefile
index db022dea5..442bffdd7 100644
--- a/Makefile
+++ b/Makefile
@@ -24,8 +24,7 @@ install:
 	ln -s $(pkgdatadir)/metrics/access/aggregate.php $(DESTDIR)$(bindir)/osrt-metrics-access-aggregate
 	ln -s $(pkgdatadir)/metrics/access/ingest.php $(DESTDIR)$(bindir)/osrt-metrics-access-ingest
 	cp -R config/* $(DESTDIR)$(sysconfdir)/$(package_name)
-	rm $(DESTDIR)$(sysconfdir)/$(package_name)/logrotate
-	install -Dpm0644 config/logrotate $(DESTDIR)$(sysconfdir)/logrotate.d/$(package_name)
+	install -Dpm0644 slsa/logrotate $(DESTDIR)$(sysconfdir)/logrotate.d/$(package_name)
 	for dir in dashboards datasources ; do ln -s $(pkgdatadir)/metrics/grafana/provisioning/$$dir.yaml \
 	  $(DESTDIR)$(grafana_provisioning_dir)/$$dir/$(package_name).yaml ; done
 	sed -i "s|OSRT_DATA_DIR|$(pkgdatadir)|" \
diff --git a/dist/package/openSUSE-release-tools.spec b/dist/package/openSUSE-release-tools.spec
index 502aab3da..0de5f9cef 100644
--- a/dist/package/openSUSE-release-tools.spec
+++ b/dist/package/openSUSE-release-tools.spec
@@ -319,6 +319,7 @@ OSC plugin for the staging workflow, see `osc staging --help`.
 
 %build
 %make_build
+%sysusers_generate_pre slsa/osrt-slsa-user.conf %{name} %{name}.conf
 
 %install
 %make_install \
@@ -326,6 +327,11 @@ OSC plugin for the staging workflow, see `osc staging --help`.
   oscplugindir="%{osc_plugin_dir}" \
   VERSION="%{version}"
 
+install -Dpm0644 slsa/osrt-slsa-user.conf %{buildroot}%{_sysusersdir}/%{name}.conf
+
+%pre -f %{name}.pre
+%service_add_pre %{name}.service
+
 %pre announcer
 getent passwd osrt-announcer > /dev/null || \
   useradd -r -m -s /sbin/nologin -c "user for openSUSE-release-tools-announcer" osrt-announcer
@@ -370,9 +376,6 @@ exit 0
 
 %pre slsa-build-service
 %service_add_pre %{services}
-getent passwd osrt-slsa > /dev/null || \
-  useradd -r -d /var/lib/osrt-slsa -s /sbin/nologin -c "user for openSUSE-release-tools-slsa-build-service" osrt-slsa
-exit 0
 
 %post slsa-build-service
 %service_add_post %{services}
@@ -469,6 +472,7 @@ exit 0
 %{_datadir}/%{source_dir}/verify-build-and-generatelists
 %{_datadir}/%{source_dir}/verify-repo-built-successful.py
 %{_sysconfdir}/openSUSE-release-tools/ibsapi
+%{_sysusersdir}/%{name}.conf
 %{_unitdir}/osrt-pkglistgen@.service
 %{_unitdir}/osrt-pkglistgen@.timer
 %{_unitdir}/osrt-relpkggen@.service
diff --git a/config/logrotate b/slsa/logrotate
similarity index 100%
rename from config/logrotate
rename to slsa/logrotate
diff --git a/slsa/osrt-slsa-user.conf b/slsa/osrt-slsa-user.conf
new file mode 100644
index 000000000..41be4f0fb
--- /dev/null
+++ b/slsa/osrt-slsa-user.conf
@@ -0,0 +1,2 @@
+# Type Name ID GECOS [HOME]
+u osrt-slsa - "User for openSUSE SLSA release tool" /var/lib/osrt-slsa