Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide future of NonFree workflow #1247

Closed
jberry-suse opened this issue Nov 9, 2017 · 10 comments
Closed

Decide future of NonFree workflow #1247

jberry-suse opened this issue Nov 9, 2017 · 10 comments
Assignees

Comments

@jberry-suse
Copy link
Contributor

@jberry-suse jberry-suse commented Nov 9, 2017

It seems the staging tools no longer properly handle requests targeting NonFree subproject. I feel like I remember something about this a while back, but likely the recent changes to source checker and what not that load StagingAPI will not handle for this as well. The primary bit seems like the staging plugin itself.

For example take a look at the three requests to Factory:NonFree currently open.

@nilxam

This comment has been minimized.

Copy link
Contributor

@nilxam nilxam commented Nov 13, 2017

I thought it's not about staging plugin itself but repo-checker can not accept it, those requests were force accepted but the repo-checker review does not be accepted. IIRC old repochecker accept them if it builds in the devel project.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

@jberry-suse jberry-suse commented Nov 29, 2017

Well, I they do not appear to get staged. repo-checker just looks for reviews assigned to it, but since they are never staged they never are "ready" to review.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

@jberry-suse jberry-suse commented Jan 11, 2018

The previous repo-checker reviewed build results from the devel project so the packages would not need to be staged and other ReviewBots handle the :NonFree. The staging bits appear to have never been capable of staging requests targeting :NonFree. Two questions come to mind:

  1. Should :NonFree requests be staged as part of the normal workflow? (would resolve the next question)
  2. Should the repo-checker review be skipped entirely for :NonFree requests? (either by repo-checker just accepting them or likely better factory-auto never issuing a review request)

Unless there is a legal reason, choosing to stage :NonFree requests seems to be the best option.

@jberry-suse jberry-suse changed the title NonFree workflow broken Decide future of NonFree workflow Jan 11, 2018
@jberry-suse jberry-suse removed the regression label Jan 11, 2018
@DimStar77

This comment has been minimized.

Copy link
Contributor

@DimStar77 DimStar77 commented Jan 11, 2018

Since we do not publish the staging projects, we should be fine to build those source also there (no redistribution outside of the standard nonoss repo) - and imho, x:NonFree should be included as part of the normal staging process (if x:NonFree exists of course; not the case for SLE)

When setting up the adi project, it needs to build against x:NonFree, as otherwise there are chances of repo-checker not finding dependencies (think the various -data in there, needing also binaries next to it); and of course overlaid over openSUSE:Factory

@nilxam

This comment has been minimized.

Copy link
Contributor

@nilxam nilxam commented Jan 11, 2018

We should go with

Should :NonFree requests be staged as part of the normal workflow? (would resolve the next question)

I''m work on it already.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

@jberry-suse jberry-suse commented Jan 31, 2018

For posterity, related PR #1379.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

@jberry-suse jberry-suse commented Aug 17, 2018

One approach to explore post #1650, would be to define a :NonFree pattern that excludes the :NonFree part from project name and points to target project (ie leap and Factory). This would effectively make the staging key the target project instead of :NonFree:Staging and may be enough to cleanly trick all the tools to do what we want.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

@jberry-suse jberry-suse commented Aug 17, 2018

Related #1016 as devel-projects does not include :NonFree which may or may not be relevant depending on how that issue goes forward.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

@jberry-suse jberry-suse commented Aug 17, 2018

Since also published separate it may make sense to simply point the dashboard container to store things for :NonFree there like devel list and repo_checker output and run those services against the project as well. As the only part that is shared is the staging which is the tricky bit.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

@jberry-suse jberry-suse commented Oct 18, 2018

This problem has gotten simpler with all the config rework I did as repo_checker is now the only using of ReviewBot.staging_api(). That combined with other cleanups means the approach of matching the NonFree sub-project, but not including in project regex group should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.