Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo_checker: store and compare build hash to skip more aggressively (similar check for project_only) #1229

Merged
merged 4 commits into from Nov 1, 2017

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Oct 27, 2017

  • 95777e1:
    repo_checker: project_only place dashboard update behind dryrun check.

  • b8d81e1:
    repo_checker: project_only ensure project repository is published.

  • 9b7d121:
    repo_checker: store and compare build hash to skip more aggressively.

Fixes #973.
Fixes #1029.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Oct 27, 2017

packagelists is rather under-powered for this bot and the addition of Leap:15.0 does not help. Effectively should skip re-reviewing stagings until their build changes. This should also allow the project_only mode to run without producing false-negatives during rebuilds. As such I will go ahead and enable it.

@jberry-suse jberry-suse force-pushed the jberry-suse:repo_checker-build-state branch from 95777e1 to f5b623d Oct 27, 2017
@openSUSE openSUSE deleted a comment from coveralls Oct 27, 2017
@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Oct 31, 2017

The down-side of this is that if the whitelist is updated repo-checker will not recheck the staging.

@DimStar77

This comment has been minimized.

Copy link
Contributor

DimStar77 commented Oct 31, 2017

For adi, there might also be changes in oS:F directly that alter the outcome of the check (think install deps were missing, then accepted through a different adi staging). The fact that setting confug won't be cinsidered for change/rescan is kinda a bummer

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Oct 31, 2017

This caches all relevant repos so it would detect that change. Basically all the repos it downloads to check it includes in the hash. If anything I just need to add config hash.

@jberry-suse jberry-suse force-pushed the jberry-suse:repo_checker-build-state branch from f5b623d to 83bf4c6 Oct 31, 2017
@openSUSE openSUSE deleted a comment from coveralls Oct 31, 2017
@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Oct 31, 2017

Cleaned up code a tad so it can cache more, and included staging project meta revision in hash to detect config changes.

@jberry-suse jberry-suse force-pushed the jberry-suse:repo_checker-build-state branch from 83bf4c6 to 9aeb0a4 Oct 31, 2017
@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Oct 31, 2017

For reference the last repo-checker run on packageslists:

  • Oct 31 18:24:18
  • Oct 31 23:39:33

Over 5 hours. I would expect this to drop that by 80% at least.

@openSUSE openSUSE deleted a comment from coveralls Oct 31, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage decreased (-0.08%) to 31.179% when pulling 9aeb0a4 on jberry-suse:repo_checker-build-state into c32b59b on openSUSE:master.

@jberry-suse jberry-suse merged commit 0e1733f into openSUSE:master Nov 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:repo_checker-build-state branch Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.