Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osc vdelreq: new command lists pending virtually accepted delete request status #1238

Merged
merged 2 commits into from Nov 3, 2017

Conversation

@nilxam
Copy link
Contributor

nilxam commented Nov 1, 2017

maxlin@tigercity:~/.osc-plugins $ osc vdelreq list openSUSE:Factory
536563 lxqt-common state is review 
       - Virtually accept review is new ( binary: Yes )

maxlin@tigercity:~/.osc-plugins $ osc vdelreq list --all openSUSE:Factory
527486 python-argparse state is accepted 
       - Virtually accept review is accepted ( binary: No )
528637 vlock state is accepted 
       - Virtually accept review is accepted ( binary: No )
529955 perl-CPAN-Meta state is accepted 
       - Virtually accept review is accepted ( binary: No )
529956 perl-CPAN-Meta-YAML state is accepted 
       - Virtually accept review is accepted ( binary: No )
530181 keybinder3 state is accepted 
       - Virtually accept review is accepted ( binary: No )
530703 perl-YAML-Perl state is accepted 
       - Virtually accept review is accepted ( binary: No )
530796 perl-PerlIO-eol state is accepted 
       - Virtually accept review is accepted ( binary: No )
530963 virtaal state is accepted 
       - Virtually accept review is accepted ( binary: No )
531141 mhtml-firefox state is accepted 
       - Virtually accept review is accepted ( binary: No )
531259 python3-jupyter_sphinx_theme state is accepted 
       - Virtually accept review is accepted ( binary: No )
531764 python3-PyWebDAV3-GNUHealth state is accepted 
       - Virtually accept review is accepted ( binary: No )
531766 python3-aiohttp state is accepted 
       - Virtually accept review is accepted ( binary: No )
531767 python3-minidb state is accepted 
       - Virtually accept review is accepted ( binary: No )
531768 python3-python3-openid state is accepted 
       - Virtually accept review is accepted ( binary: No )
531769 python3-websockets state is accepted 
       - Virtually accept review is accepted ( binary: No )
531871 python3-jupyter_ipython state is accepted 
       - Virtually accept review is accepted ( binary: No )
532337 gcc-java state is accepted 
       - Virtually accept review is accepted ( binary: No )
532338 gcc6 state is accepted 
       - Virtually accept review is accepted ( binary: No )
532339 java-1_5_0-gcj-compat state is accepted 
       - Virtually accept review is accepted ( binary: No )
532558 typo3-flow-1_1 state is accepted 
       - Virtually accept review is accepted ( binary: No )
532700 android-tools state is accepted 
       - Virtually accept review is accepted ( binary: No )
532729 pdftk state is accepted 
       - Virtually accept review is accepted ( binary: No )
532915 perl-Data-AMF state is accepted 
       - Virtually accept review is accepted ( binary: No )
533017 python3-WTForms state is accepted 
       - Virtually accept review is accepted ( binary: No )
533018 python3-Flask-WTF state is accepted 
       - Virtually accept review is accepted ( binary: No )
533424 gnome-mime-data state is accepted 
       - Virtually accept review is accepted ( binary: No )
533549 perl-Clipboard state is accepted 
       - Virtually accept review is accepted ( binary: No )
533959 PlotDigitizer state is accepted 
       - Virtually accept review is accepted ( binary: No )
534001 python-poppler-qt4 state is accepted 
       - Virtually accept review is accepted ( binary: No )
534126 s2tc state is accepted 
       - Virtually accept review is accepted ( binary: No )
534215 rubygem-minitest state is accepted 
       - Virtually accept review is accepted ( binary: No )
534252 python-puppetboard state is accepted 
       - Virtually accept review is accepted ( binary: No )
534253 python-pypuppetdb state is accepted 
       - Virtually accept review is accepted ( binary: No )
534254 rubygem-puppet state is accepted 
       - Virtually accept review is accepted ( binary: No )
534255 rubygem-puppet-lint state is accepted 
       - Virtually accept review is accepted ( binary: No )
534256 rubygem-puppet-syntax state is accepted 
       - Virtually accept review is accepted ( binary: No )
534257 rubygem-puppet_forge state is accepted 
       - Virtually accept review is accepted ( binary: No )
534258 rubygem-quixoten-puppetdb-terminus state is accepted 
       - Virtually accept review is accepted ( binary: No )
534259 rubygem-rspec-puppet state is accepted 
       - Virtually accept review is accepted ( binary: No )
534260 rubygem-semantic_puppet state is accepted 
       - Virtually accept review is accepted ( binary: No )
534261 rubygem-mcollective state is accepted 
       - Virtually accept review is accepted ( binary: No )
534262 rubygem-facter state is accepted 
       - Virtually accept review is accepted ( binary: No )
534263 rubygem-hiera state is accepted 
       - Virtually accept review is accepted ( binary: No )
534264 rubygem-hiera-eyaml state is accepted 
       - Virtually accept review is accepted ( binary: No )
534265 rubygem-hiera-eyaml-gpg state is accepted 
       - Virtually accept review is accepted ( binary: No )
534266 rubygem-r10k state is accepted 
       - Virtually accept review is accepted ( binary: No )
534267 rubygem-ra10ke state is accepted 
       - Virtually accept review is accepted ( binary: No )
534484 ghc-gtksourceview3 state is accepted 
       - Virtually accept review is accepted ( binary: No )
534622 perl-MooseX-Types-Parameterizable state is accepted 
       - Virtually accept review is accepted ( binary: No )
534952 gkrellm-cpufreq state is accepted 
       - Virtually accept review is accepted ( binary: No )
535178 q-tools state is accepted 
       - Virtually accept review is accepted ( binary: No )
535733 esound state is accepted 
       - Virtually accept review is accepted ( binary: No )
535779 ksshaskpass state is accepted 
       - Virtually accept review is accepted ( binary: No )
536040 rubygem-fast_gettext-1_1 state is accepted 
       - Virtually accept review is accepted ( binary: No )
536041 rubygem-cri-2_6 state is accepted 
       - Virtually accept review is accepted ( binary: No )
536042 rubygem-faraday_middleware-0_9 state is accepted 
       - Virtually accept review is accepted ( binary: No )
536065 pdfchain state is accepted 
       - Virtually accept review is accepted ( binary: No )
536563 lxqt-common state is review 
       - Virtually accept review is new ( binary: Yes )

relating to #1164

@nilxam nilxam force-pushed the nilxam:vdelreq_command branch 2 times, most recently from 7df7e67 to caa14cf Nov 1, 2017
@openSUSE openSUSE deleted a comment from coveralls Nov 1, 2017
@openSUSE openSUSE deleted a comment from coveralls Nov 1, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 1, 2017

Coverage Status

Coverage decreased (-0.03%) to 31.151% when pulling caa14cf on nilxam:vdelreq_command into d8cd193 on openSUSE:master.

@jberry-suse

This comment has been minimized.

Copy link
Contributor

jberry-suse commented Nov 1, 2017

  • Any reason for not making it apart of osc-staging as it requires the other staging bits to function? If it remains, perhaps add to Makefile install and spec.
  • On cosmetic side, any reason to include DR# prefix as I removed the sr# prefix on list to make it easy to copy out of console. Similarly, perhaps use column layout like list unless there is a reason to write it out verbosely.
@nilxam

This comment has been minimized.

Copy link
Contributor Author

nilxam commented Nov 2, 2017

Any reason for not making it apart of osc-staging as it requires the other staging bits to function? If it remains, perhaps add to Makefile install and spec.

There is a discussion between @DimStar77 and me about this command, we both agreed it should be another command than being part of the staging command, because the request was passed staging project already, that is staging-manager unable to handle those request anyways, basically this command should just useful for release manager(aka target maintainer).

On cosmetic side, any reason to include DR# prefix as I removed the sr# prefix on list to make it easy to copy out of console. Similarly, perhaps use column layout like list unless there is a reason to write it out verbosely.

OK, I'll change the layout align to list command did.

@nilxam nilxam force-pushed the nilxam:vdelreq_command branch from caa14cf to 3468fe8 Nov 2, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage decreased (-0.02%) to 31.151% when pulling 3468fe8 on nilxam:vdelreq_command into 0a45aba on openSUSE:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage decreased (-0.02%) to 31.151% when pulling 6efaa1d on nilxam:vdelreq_command into 0a45aba on openSUSE:master.

Copy link
Contributor

jberry-suse left a comment

Considering this as outside of staging process makes sense as you explained. The end of staging process simply transitions it into this process instead of accepting.

@nilxam nilxam merged commit f5bc6b6 into openSUSE:master Nov 3, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nilxam nilxam deleted the nilxam:vdelreq_command branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.