Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't die on delete requests #1240

Merged
merged 1 commit into from Nov 9, 2017
Merged

Don't die on delete requests #1240

merged 1 commit into from Nov 9, 2017

Conversation

@lnussel
Copy link
Member

lnussel commented Nov 2, 2017

Perform src_project checks only on actions that actually have a
src_project

closes #1239

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage remained the same at 31.174% when pulling 4bc24ce on lnussel:master into 0a45aba on openSUSE:master.

@@ -96,7 +96,7 @@ def _check_maintainer_review_needed(self, req, a):
pkgname = a.tgt_package
project = a.tgt_project

if project.startswith('openSUSE:Leap:'):
if project.startswith('openSUSE:Leap:') and 'src_project' in dir(a):

This comment has been minimized.

Copy link
@jberry-suse

jberry-suse Nov 2, 2017

Contributor

The more correct way I believe is hasattr(a, 'src_project').

This comment has been minimized.

Copy link
@jberry-suse

jberry-suse Nov 2, 2017

Contributor

That said in python 3.6 apparently 'src_project' in a works.

Perform src_project checks only on actions that actually have a
src_project
@lnussel lnussel force-pushed the lnussel:master branch from 4bc24ce to 312c180 Nov 9, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 9, 2017

Coverage Status

Coverage remained the same at 31.151% when pulling 312c180 on lnussel:master into 593c900 on openSUSE:master.

@jberry-suse jberry-suse merged commit bcdea68 into openSUSE:master Nov 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.