Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo_checker: only update comment if published or message changed. #1316

Merged

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Dec 30, 2017

In effect, only update comment when either:

  • target project is published and build hash has changed
  • comment changed

Best of both worlds presumably.

Changes the identical comment comparison to first strip the comment marker before comparing text to allow for non-identical info_extra to be present in comments that are compared.

Still some edge-cases for long-running cases where state changes during/before review, but at most a second comment might result for one project.

In the process of testing more extensively.

Fixes #1296.

jberry-suse added 2 commits Dec 30, 2017
Allows for excluding info_extra from comment_find() and compares messages
after marker has been removed.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 30, 2017

Coverage Status

Coverage decreased (-0.01%) to 29.961% when pulling 456a7c8 on jberry-suse:repo-checker-info_extra_identical into 96a3eec on openSUSE:master.

@lnussel lnussel merged commit 98a659c into openSUSE:master Jan 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:repo-checker-info_extra_identical branch Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.